-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: refine conditional exports documentation #32098
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
esm
Issues and PRs related to the ECMAScript Modules implementation.
labels
Mar 4, 2020
guybedford
changed the title
docs: update conditional exports recommendations
docs: refine conditional exports documentation
Mar 4, 2020
Discussing this further, early 13.x support not working isn't that bad, and it may make sense not to skew things towards this compatibility after all. I've completely pulled this back to just be a docs refactoring in that case. |
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
@GeoffreyBooth thanks for the initial review - I've added some further refactorings here in 74206e7. If you have a moment to review that would be great. |
ljharb
reviewed
Mar 6, 2020
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com>
GeoffreyBooth
approved these changes
Mar 11, 2020
addaleax
pushed a commit
that referenced
this pull request
Mar 13, 2020
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com> PR-URL: #32098 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Landed in 04028aa |
BridgeAR
pushed a commit
that referenced
this pull request
Mar 17, 2020
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com> PR-URL: #32098 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 24, 2020
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com> PR-URL: #32098 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Apr 3, 2020
Co-Authored-By: Geoffrey Booth <GeoffreyBooth@users.noreply.github.com> PR-URL: nodejs#32098 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This began as a bigger change of guidance but has been pulled back to a simple docs refactoring.
Resolves #32107.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes