Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v13.x backport] stream: async iterator improvements #32174

Closed
wants to merge 2 commits into from
Closed

[v13.x backport] stream: async iterator improvements #32174

wants to merge 2 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Mar 10, 2020 •
edited
Loading

PR-URL: #31316

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag requested a review from MylesBorins March 10, 2020 13:07
@ronag
stream: simplify pipeline
0abd4f0 
PR-URL: nodejs#31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Backport-PR-URL: nodejs#32174
@ronag
stream: re-use legacy destroyer
2578e5d 
PR-URL: nodejs#31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Backport-PR-URL: nodejs#32174
@ronag ronag mentioned this pull request Mar 10, 2020
Closed
7 tasks
@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Mar 10, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29692/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 10, 2020 •
edited by MylesBorins
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/29693/
retry-osx: https://ci.nodejs.org/job/node-test-commit-osx/32522/

MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@ronag @MylesBorins
stream: simplify pipeline
7ce1cc9 
Backport-PR-URL: #32174
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@ronag @MylesBorins
stream: re-use legacy destroyer
4b04bf8 
Backport-PR-URL: #32174
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@MylesBorins
Copy link
Contributor

laded in 9d1b1a3...4b04bf8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins Awaiting requested review from MylesBorins

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronag @nodejs-github-bot @MylesBorins