Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: expand fs.watch caveats #32176

Closed
wants to merge 2 commits into from
Closed

doc: expand fs.watch caveats #32176

wants to merge 2 commits into from

Conversation

bzoz
Copy link
Contributor

@bzoz bzoz commented Mar 10, 2020

Document Windows specific fs.watch caveats.

Fixes: #31702

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@bzoz
doc: expand fs.watch caveats
e391cca 
Document Windows specific fs.watch caveats.

Fixes: nodejs#31702
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Mar 10, 2020
bnoordhuis
bnoordhuis approved these changes Mar 10, 2020
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Mar 11, 2020
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
@bzoz
Copy link
Contributor Author

bzoz commented Mar 11, 2020

Updated, PTAL

@addaleax
Copy link
Member

Landed in 1a844a6

@addaleax addaleax closed this Mar 13, 2020
addaleax pushed a commit that referenced this pull request Mar 13, 2020
@bzoz @addaleax
doc: expand fs.watch caveats
1a844a6 
Document Windows specific fs.watch caveats.

Fixes: #31702

PR-URL: #32176
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 17, 2020
@bzoz @BridgeAR
doc: expand fs.watch caveats
038a463 
Document Windows specific fs.watch caveats.

Fixes: #31702

PR-URL: #32176
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 19, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@bzoz @MylesBorins
doc: expand fs.watch caveats
5080734 
Document Windows specific fs.watch caveats.

Fixes: #31702

PR-URL: #32176
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
@bzoz @targos
doc: expand fs.watch caveats
76e2455 
Document Windows specific fs.watch caveats.

Fixes: #31702

PR-URL: #32176
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@shisama shisama shisama approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fs.watch doesn't emit change event when a watched folder is moved or deleted on Windows
9 participants
@bzoz @addaleax @bnoordhuis @jasnell @Trott @lpinca @cjihrig @shisama @nodejs-github-bot