Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove unused gflags module #3220

Merged
merged 1 commit into from
Oct 6, 2015

Conversation

bnoordhuis
Copy link
Member

Its only dependant was closure-linter but that was removed in commit
f9dd34d ("tools: replace closure-linter with eslint"). Remove it.

Fixes: #3217

CI: https://ci.nodejs.org/job/node-test-pull-request/433/

@bnoordhuis bnoordhuis added the tools Issues and PRs related to the tools directory. label Oct 6, 2015
@trevnorris
Copy link
Contributor

LGTM if CI is happy.

Its only dependant was closure-linter but that was removed in commit
f9dd34d ("tools: replace closure-linter with eslint").  Remove it.

Fixes: nodejs#3217
PR-URL: nodejs#3220
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis bnoordhuis closed this Oct 6, 2015
@bnoordhuis bnoordhuis deleted the remove-gflags branch October 6, 2015 20:51
@bnoordhuis bnoordhuis merged commit 87d2615 into nodejs:master Oct 6, 2015
@bnoordhuis
Copy link
Member Author

Sigh, test-stringbytes-external.js on ARM again... landed in 87d2615 and thanks for the review, Trevor.

@jasnell jasnell mentioned this pull request Oct 8, 2015
29 tasks
bnoordhuis added a commit that referenced this pull request Oct 8, 2015
Its only dependant was closure-linter but that was removed in commit
f9dd34d ("tools: replace closure-linter with eslint").  Remove it.

Fixes: #3217
PR-URL: #3220
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants