Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps,doc: move openssl maintenance guide to doc #32209

Closed
wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

@sam-github sam-github commented Mar 11, 2020

The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the openssl Issues and PRs related to the OpenSSL dependency. label Mar 11, 2020
@sam-github sam-github force-pushed the maintaining-openssl branch from e8ac0c3 to f1b7027 Compare March 12, 2020 16:59
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.
@sam-github sam-github force-pushed the maintaining-openssl branch from f1b7027 to 722f2fe Compare March 12, 2020 17:19
@jasnell
Copy link
Member

jasnell commented Mar 12, 2020

Can we fasttrack this?

@sam-github sam-github added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 13, 2020
@sam-github
Copy link
Contributor Author

I'm OK with it, not sure how many +1s we need.

jasnell pushed a commit that referenced this pull request Mar 17, 2020
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.

PR-URL: #32209
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 17, 2020

Landed in 5eb85dd

@jasnell jasnell closed this Mar 17, 2020
MylesBorins pushed a commit that referenced this pull request Mar 19, 2020
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.

PR-URL: #32209
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 19, 2020
@sam-github sam-github deleted the maintaining-openssl branch March 20, 2020 21:34
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.

PR-URL: #32209
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so
move the OpenSSL one there, too.

PR-URL: #32209
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants