Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: change var to let/const in lib stream js files. #32214

Closed
wants to merge 1 commit into from
Closed

stream: change var to let/const in lib stream js files. #32214

wants to merge 1 commit into from

Conversation

Saajan
Copy link
Contributor

@Saajan Saajan commented Mar 11, 2020 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Mar 11, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29763/

@Saajan Saajan changed the title "var" in lib stream js files changed to "let" and "const". lib:"var" in lib stream js files changed to "let" and "const". Mar 12, 2020
@trivikr
Copy link
Member

trivikr commented Mar 18, 2020

@Saajan This needs rebase as _stream_writable.js was updated in #32037

Can you please update PR title to git commit message guidelines?
It can be stream: change var to let/const for example

@Saajan Saajan changed the title lib:"var" in lib stream js files changed to "let" and "const". stream: change var to let/const in lib stream js files. Mar 18, 2020
@Saajan
Copy link
Contributor Author

Saajan commented Mar 18, 2020

@Saajan This needs rebase as _stream_writable.js was updated in #32037

Can you please update PR title to git commit message guidelines?
It can be stream: change var to let/const for example

Thank you for the suggestions. I have done the changes you asked.

@Saajan Saajan requested a review from ronag March 20, 2020 07:32
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30206/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30230/

@addaleax
Copy link
Member

Landed in 4fc13b0 🎉

@addaleax addaleax closed this Mar 30, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@Saajan @addaleax
stream: change var to let/const in stream files
4fc13b0 
PR-URL: #32214
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@Saajan @addaleax
stream: change var to let/const in stream files
cad768e 
PR-URL: #32214
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Apr 13, 2020
Merged
@targos targos added backport-blocked-v12.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@ronag ronag ronag approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Saajan @nodejs-github-bot @trivikr @addaleax @jasnell @ronag @targos