-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: don't emit 'readable' after 'close' #32277
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess optimally |
ronag
force-pushed
the
http-close-readable
branch
from
March 15, 2020 12:39
600401d
to
c48885a
Compare
@nodejs/http |
jasnell
reviewed
Mar 19, 2020
jasnell
reviewed
Mar 19, 2020
@nodejs/http |
Suspicious failure on CI. |
addaleax
approved these changes
Mar 29, 2020
addaleax
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Mar 29, 2020
jasnell
approved these changes
Mar 29, 2020
Landed in e034f5c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
http
Issues or PRs related to the http subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An edge case could emit 'readable' after 'close' and 'close' before 'end'.
Refs: #28710
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes