src: Fix extra includes of "env.h" and "env-inl.h" in this directory. #32293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
himself65
reviewed
Mar 16, 2020
There was a problem hiding this comment.
Commit message should be like 3bb085d Or 902f5d9
src: change env.h includes for forward declarations
Due to how the Environment class is used through the codebase,
there are a lot of includes referencing either env.h or env-inl.h.
This can cause that when any development touches those libraries,
a lot of files have to be recompiled.
This commit attempts to change those includes by forward declarations
when possible to mitigate the issue.
Due to how the Environment class is used throughout the codebase, there are a log of includes referencing eitehr env.h or env-inl.h. This commit cleans up the remaining extra includes of 'env.h' or 'env-inl.h' and adds forward declarations of the Environment class. PR-URL: nodejs#32293 Refs: nodejs#27531
nkreeger
force-pushed
the
kreeger/include-fixes
branch
from
8735d88
to
3e26be9
Compare
|
addaleax
reviewed
Mar 16, 2020
src/node_http_common-inl.h
Outdated
| @@ -4,7 +4,6 @@ | |||
| #include "node_http_common.h" | |||
| #include "node.h" | |||
| #include "node_mem-inl.h" | |||
| #include "env-inl.h" | |||
There was a problem hiding this comment.
If removing this works, then it’s by accident – this file does require env-inl.h in order to work. Please leave the include here.
(You can test this by including only node_http_common-inl.h from a .cc file – compiling that file will fail without this line.)
There was a problem hiding this comment.
I can guarantee that removing this would break on some of the platforms as I had omitted this originally and had to fix it.
There was a problem hiding this comment.
Great thanks - any tips on better build testing? I git grep'ing for these items in header files and running make -j8 test as a blanket test. I see the x-platform integration tests pass...
@jasnell Please let me know if I'm stomping on anything you're doing. Just looking for some fun side-hacking :-)
There was a problem hiding this comment.
Nope you're good :-) ... I'll adjust on my end if there are any merge conflicts.
addaleax
approved these changes
Mar 17, 2020
jasnell
approved these changes
Mar 17, 2020
|
Friendly ping on this - any other reviewers I should include? |
addaleax
added
the
author ready
|
@nkreeger Thanks for the ping! I’ll kick off a fresh CI run and we can land this quite soon, probably. |
addaleax
pushed a commit
that referenced
this pull request
Apr 2, 2020
Due to how the Environment class is used throughout the codebase, there are a log of includes referencing eitehr env.h or env-inl.h. This commit cleans up the remaining extra includes of 'env.h' or 'env-inl.h' and adds forward declarations of the Environment class. PR-URL: #32293 Refs: #27531 Fixes: #27531 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 12a2997, and thank you for your patience! 🎉 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
Due to how the Environment class is used throughout the codebase, there are a log of includes referencing eitehr env.h or env-inl.h. This commit cleans up the remaining extra includes of 'env.h' or 'env-inl.h' and adds forward declarations of the Environment class. PR-URL: #32293 Refs: #27531 Fixes: #27531 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
Due to how the Environment class is used throughout the codebase, there are a log of includes referencing eitehr env.h or env-inl.h. This commit cleans up the remaining extra includes of 'env.h' or 'env-inl.h' and adds forward declarations of the Environment class. PR-URL: #32293 Refs: #27531 Fixes: #27531 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
added
backport-blocked-v12.x
and removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Due to how the Environment class is used throughout the codebase, there are a log of includes referencing eitehr env.h or env-inl.h. This commit cleans up the remaining extra includes of 'env.h' or 'env-inl.h' and adds forward declarations of the Environment class. PR-URL: nodejs#32293 Refs: nodejs#27531 Fixes: nodejs#27531 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Due to how the Environment class is used throughout the codebase, there are a log of includes referencing eitehr env.h or env-inl.h. This commit cleans up the remaining extra includes of 'env.h' or 'env-inl.h' and adds forward declarations of the Environment class. PR-URL: #32293 Refs: #27531 Fixes: #27531 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit should cleanup the remaining open extra includes of "env.h"
and "env-inl.h" and forward declarations of |Environment|.
Fixes: #27531
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes