Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: update comment for SetImmediate() #32300

Closed
wants to merge 1 commit into from
Closed

src: update comment for SetImmediate() #32300

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: #31502 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 16, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 20, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29947/

jasnell pushed a commit that referenced this pull request Mar 21, 2020
@addaleax @jasnell
src: update comment for SetImmediate()
064a670 
Refs: #31502 (comment)

PR-URL: #32300
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 21, 2020

Landed in 064a670

@jasnell jasnell closed this Mar 21, 2020
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@addaleax @MylesBorins
src: update comment for SetImmediate()
11650c6 
Refs: #31502 (comment)

PR-URL: #32300
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 24, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@addaleax @targos
src: update comment for SetImmediate()
7a346f6 
Refs: #31502 (comment)

PR-URL: #32300
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @nodejs-github-bot @jasnell @cjihrig @devnexen