Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: only inspect error properties that are not visible otherwise #32327

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

Inspecting errors results in duplicated information in case an error
is created with enumerable name, message or stack properties.
In that case, check if the output already contains that information
and prevent listing that property.

This reduces the noise as receiver.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Inspecting errors results in duplicated information in case an error
is created with enumerable `name`, `message` or `stack` properties.
In that case, check if the output already contains that information
and prevent listing that property.

This reduces the noise as receiver.
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Mar 17, 2020
@BridgeAR
Copy link
Member Author

@nodejs/util PTAL

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 30, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30256/ (:heavy_check_mark:)

addaleax pushed a commit that referenced this pull request Apr 2, 2020
Inspecting errors results in duplicated information in case an error
is created with enumerable `name`, `message` or `stack` properties.
In that case, check if the output already contains that information
and prevent listing that property.

This reduces the noise as receiver.

PR-URL: #32327
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@addaleax
Copy link
Member

addaleax commented Apr 2, 2020

Landed in 6baddcf

@addaleax addaleax closed this Apr 2, 2020
@addaleax addaleax deleted the 2020-03-17-hide-duplicated-error-properties branch April 2, 2020 16:42
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
Inspecting errors results in duplicated information in case an error
is created with enumerable `name`, `message` or `stack` properties.
In that case, check if the output already contains that information
and prevent listing that property.

This reduces the noise as receiver.

PR-URL: #32327
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
Inspecting errors results in duplicated information in case an error
is created with enumerable `name`, `message` or `stack` properties.
In that case, check if the output already contains that information
and prevent listing that property.

This reduces the noise as receiver.

PR-URL: #32327
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
Inspecting errors results in duplicated information in case an error
is created with enumerable `name`, `message` or `stack` properties.
In that case, check if the output already contains that information
and prevent listing that property.

This reduces the noise as receiver.

PR-URL: #32327
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants