Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update openssl to 1.1.1e #32328

Closed

Conversation

hassaanp
Copy link
Contributor

@hassaanp hassaanp commented Mar 17, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Fixes: #32210

@nodejs-github-bot nodejs-github-bot added the openssl Issues and PRs related to the OpenSSL dependency. label Mar 17, 2020
@sam-github
Copy link
Contributor

sam-github commented Mar 17, 2020

Thanks! This needs a few things:

  1. Can you rebase this against master? It seems to be branched from a week ago.
  2. Can you please follow the directions in doc/guides/maintaining-openssl.md, specifically with respect to the commit messages?
  3. When you do the above, you'll see that the commits with contents that are large but essentially machine generated have clear commit messages describing how they were made, and don't mix hand-written and auto-generated content. This makes it possible to review and approve them without reading the contents, because its clear how the content was created. Please split your updates to the configure scripts into a standalone commit, it should be after the sources update, and before the output of the configure process.

EDIT: And just a note, this branch should be force-pushed after being updated (sometimes people close PRs and open new ones if they are not so familiar with github or git, but we prefer that not be done).

@nodejs-github-bot
Copy link
Collaborator

@hassaanp
Copy link
Contributor Author

hassaanp commented Mar 18, 2020

  1. Can you rebase this against master? It seems to be branched from a week ago.

Rebased, and pushed.

  1. Can you please follow the directions in doc/guides/maintaining-openssl.md, specifically with respect to the commit messages?

Done. The original second commit where I was modifying the scripts has been split and commit messages have been appropriately rewritten according to the guide.

  1. When you do the above, you'll see that the commits with contents that are large but essentially machine generated have clear commit messages describing how they were made, and don't mix hand-written and auto-generated content. This makes it possible to review and approve them without reading the contents, because its clear how the content was created. Please split your updates to the configure scripts into a standalone commit, it should be after the sources update, and before the output of the configure process.

I have split my configuration updates to a separate commit: deps: revised paths in scripts to reflect openssl version 1.1.1e

@sam-github
Copy link
Contributor

You didn't rebase, you merged master into your local branch. Next time, do git rebase upstream/master && git push --force-with-lease (assuming you are using recommended setup of calling the nodejs/node remote upstream).

I would clean this up for you and force push, but it looks like you deselected that permission for me.

If you look at the top of this PR, you'll see it has 47 commits in it! That's not right. Because of the multiple merging from master into your branch, you'd best do an interactive rebase:

git fetch --all --prune
git rebase -i upstream/master

In the interactive, delete all the lines that are commits that you did not write. There should be only three. Also, reorder them. After, the commits will look like:


core/tls (deps/update-openssl-to-1.1.1e u+5-47) % git log upstream/master..HEAD
commit ea0429b510d1028584b6cf2da0b8e4a4067e7ac1 (HEAD -> deps/update-openssl-to-1.1.1e, pr/32328)
Author: Hassaan Pasha <hassaan.pasha@teamo.io>
Date:   Wed Mar 18 10:09:37 2020 +0500

    deps: update archs files for OpenSSL-1.1.1e
    
    After an OpenSSL source update, all the config files need to be regenerated and
     comitted by:
        $ cd deps/openssl/config
        $ make
        $ git add deps/openssl/config/archs
        $ git add deps/openssl/include

commit 9c4ff6bc9179b7d938c8441b18c901710cfdb490
Author: Hassaan Pasha <hassaan.pasha@teamo.io>
Date:   Wed Mar 18 10:17:22 2020 +0500

    deps: revised paths in scripts to reflect openssl version 1.1.1e
    
    the scripts used by make were modified to correctly reference
    the source files that were originially in crypto/include/internal
    these files are not residing in include/crypto. The base path has
    been left unaltered since that would require too many changes
    
    comitted by:
        $ git add deps/config/Makefile*
        $ git add deps/config/generate_gypi.pl
        $ git add deps/openssl/openssl/Makefile
        $ git add deps/openssl/openssl/configdata.pm
        $ git commit

commit 4e0ad52ddec2bda9b2144fcb89ec4d6e0a9732ab
Author: Hassaan Pasha <hassaan.pasha@teamo.io>
Date:   Tue Mar 17 22:14:56 2020 +0500

    deps: upgrade openssl sources to 1.1.1e

Note that last commit doesn't match the format in the guide: https://github.com/nodejs/node/blob/master/doc/guides/maintaining-openssl.md#1-obtain-and-extract-new-openssl-sources

We aren't normally this nitpicky, but the openssl maintenance should match the guide, feel free to kick this back to me and/or give me write permissions on your branch if you'd like me to do the rebasing.

@ExE-Boss
Copy link
Contributor

You didn't rebase, you merged master into your local branch.

If that was what was done, then there would only be a merge commit.

What instead happened was that master was rebased on top of this PR.

@hassaanp
Copy link
Contributor Author

hassaanp commented Mar 18, 2020

@sam-github acknowledged.
I will follow your suggestions.
I am also going to give you write access incase I am unable to sort this.
Thank you for your patience.

@sam-github sam-github force-pushed the deps/update-openssl-to-1.1.1e branch 4 times, most recently from f0cb169 to aeeee06 Compare March 18, 2020 21:18
@sam-github
Copy link
Contributor

Cleaned up and repushed.

@nodejs-github-bot
Copy link
Collaborator

@sam-github
Copy link
Contributor

OK, needs one more commit to (at least) fix test.sequential/test-tls-psk-client?

https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_zlib_x64/18781/

@hassaanp
Copy link
Contributor Author

@sam-github thanks for the help
Looking at the test now.

@hassaanp
Copy link
Contributor Author

@sam-github, I have fixed the test but the behavior displayed is a little awkward.
The socket end event is not fired until the data event is consumed. I hope I am explaining this correctly. Pushing the code, hopefully that would make more sense.

@hassaanp hassaanp force-pushed the deps/update-openssl-to-1.1.1e branch from 79f6755 to 5df62fc Compare March 19, 2020 07:46
@hassaanp
Copy link
Contributor Author

I have pushed the code. Kindly review.

@nodejs-github-bot
Copy link
Collaborator

@kapouer
Copy link
Contributor

kapouer commented Mar 19, 2020

Building 10.19.0 against shared openssl 1.1.1d i got an odd situation because tests ran against openssl 1.1.1e, and only one js test is failing: parallel/test-tls-session-cache (ppc64el but i'm not sure it's a problem with the arch in itself):
https://buildd.debian.org/status/fetch.php?pkg=nodejs&arch=ppc64el&ver=10.19.0~dfsg-2&stamp=1584648000&raw=0

@MylesBorins
Copy link
Contributor

Still seeing lots of failures in CI on this. Would be very good for us to include this in the various releases that we have targeting next tuesday. Do folks need help with moving this forward so we can meet that timeline? We likely need backport PRs to test each release line

@MylesBorins MylesBorins mentioned this pull request Mar 19, 2020
@sam-github sam-github force-pushed the deps/update-openssl-to-1.1.1e branch from 5fb6391 to c7c4fa1 Compare March 20, 2020 04:10
@sam-github
Copy link
Contributor

Pushed a fix for test/parallel/test-tls-session-cache.js

hassaanp and others added 5 commits March 20, 2020 07:23
This updates all sources in deps/openssl/openssl by:
    $ cd deps/openssl/
    $ rm -rf openssl
    $ tar zxf ~/tmp/openssl-1.1.1e.tar.gz
    $ mv openssl-1.1.1e openssl
    $ git add --all openssl
    $ git commit openssl
The scripts used by make were modified to correctly reference the source
files that were originially in crypto/include/internal, but got moved to
include/crypto.  The base path has been left unaltered since that would
require too many changes
After an OpenSSL source update, all the config files need to be
regenerated and comitted by:
    $ cd deps/openssl/config
    $ make
    $ git add deps/openssl/config/archs
    $ git add deps/openssl/include
This test was timing out after update to OpenSSL-1.1.1e.
In openssl-1.1.1e the client doesn't seem to like having the TLS
connection shut down with no data sent, so send an empty string. A
number of related issues showed up in the TLS1.3 port, so this is
not entirely surprising.
BethGriggs added a commit that referenced this pull request Mar 26, 2020
Notable changes:

- buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc)
  [#19691](#19691)
- deps:
  - update npm to 6.14.3 (Myles Borins)
    [#32368](#32368)
  - upgrade openssl sources to 1.1.1e (Hassaan Pasha)
    [#32328](#32328)
  - upgrade to libuv 1.34.2 (cjihrig)
    [#31477](#31477)
- n-api:
  - add napi\_get\_all\_property\_names (himself65)
    [#30006](#30006)
  - add APIs for per-instance state management (Gabriel Schulhof)
    [#28682](#28682)
  - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen)
    [#26128](#26128)
- tls:
  - expose keylog event on TLSSocket (Alba Mendez)
    [#27654](#27654)
  - support TLS min/max protocol defaults in CLI (Sam Roberts)
    [#27946](#27946)
- url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig)
  [#26226](#26226)

PR-URL: #31984
codebytere pushed a commit that referenced this pull request Mar 30, 2020
This updates all sources in deps/openssl/openssl by:
    $ cd deps/openssl/
    $ rm -rf openssl
    $ tar zxf ~/tmp/openssl-1.1.1e.tar.gz
    $ mv openssl-1.1.1e openssl
    $ git add --all openssl
    $ git commit openssl

PR-URL: #32328
Fixes: #32210
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 30, 2020
The scripts used by make were modified to correctly reference the source
files that were originially in crypto/include/internal, but got moved to
include/crypto.  The base path has been left unaltered since that would
require too many changes

PR-URL: #32328
Fixes: #32210
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 30, 2020
After an OpenSSL source update, all the config files need to be
regenerated and comitted by:
    $ cd deps/openssl/config
    $ make
    $ git add deps/openssl/config/archs
    $ git add deps/openssl/include

PR-URL: #32328
Fixes: #32210
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 30, 2020
This test was timing out after update to OpenSSL-1.1.1e.

PR-URL: #32328
Fixes: #32210
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 30, 2020
In openssl-1.1.1e the client doesn't seem to like having the TLS
connection shut down with no data sent, so send an empty string. A
number of related issues showed up in the TLS1.3 port, so this is
not entirely surprising.

PR-URL: #32328
Fixes: #32210
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere added a commit that referenced this pull request Mar 30, 2020
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
codebytere added a commit that referenced this pull request Apr 1, 2020
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
BethGriggs added a commit that referenced this pull request Apr 3, 2020
Notable changes:

- buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc)
  [#19691](#19691)
- build: macOS package notarization (Rod Vagg)
  [#31459](#31459)
- deps:
  - update npm to 6.14.3 (Myles Borins)
    [#32368](#32368)
  - upgrade openssl sources to 1.1.1e (Hassaan Pasha)
    [#32328](#32328)
  - upgrade to libuv 1.34.2 (cjihrig)
    [#31477](#31477)
- n-api:
  - add napi\_get\_all\_property\_names (himself65)
    [#30006](#30006)
  - add APIs for per-instance state management (Gabriel Schulhof)
    [#28682](#28682)
  - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen)
    [#26128](#26128)
- tls:
  - expose keylog event on TLSSocket (Alba Mendez)
    [#27654](#27654)
  - support TLS min/max protocol defaults in CLI (Sam Roberts)
    [#27946](#27946)
- url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig)
  [#26226](#26226)

PR-URL: #31984
codebytere added a commit that referenced this pull request Apr 3, 2020
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
codebytere added a commit that referenced this pull request Apr 4, 2020
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
codebytere added a commit that referenced this pull request Apr 5, 2020
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
BethGriggs added a commit that referenced this pull request Apr 6, 2020
Notable changes:

- buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc)
  [#19691](#19691)
- build: macOS package notarization (Rod Vagg)
  [#31459](#31459)
- deps:
  - update npm to 6.14.3 (Myles Borins)
    [#32368](#32368)
  - upgrade openssl sources to 1.1.1e (Hassaan Pasha)
    [#32328](#32328)
  - upgrade to libuv 1.34.2 (cjihrig)
    [#31477](#31477)
- n-api:
  - add napi\_get\_all\_property\_names (himself65)
    [#30006](#30006)
  - add APIs for per-instance state management (Gabriel Schulhof)
    [#28682](#28682)
  - define release 6
    [#32058](#32058)
  - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen)
    [#26128](#26128)
- tls:
  - expose keylog event on TLSSocket (Alba Mendez)
    [#27654](#27654)
  - support TLS min/max protocol defaults in CLI (Sam Roberts)
    [#27946](#27946)
- url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig)
  [#26226](#26226)

PR-URL: #31984
BethGriggs added a commit that referenced this pull request Apr 7, 2020
macOS package notarization and a change in builder configuration

The macOS binaries for this release, and future 10.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing .pkg files on macOS
10.15 and later. Previous builds of Node.js 10.x were compiled on macOS
10.7 (Lion). As binaries are still being compiled to support a minimum
of macOS 10.7 (Lion) we do not anticipate this having a negative impact
on Node.js 10.x users with older versions of macOS.

Notable changes:

- buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc)
  [#19691](#19691)
- build: macOS package notarization (Rod Vagg)
  [#31459](#31459)
- deps:
  - update npm to 6.14.3 (Myles Borins)
    [#32368](#32368)
  - upgrade openssl sources to 1.1.1e (Hassaan Pasha)
    [#32328](#32328)
  - upgrade to libuv 1.34.2 (cjihrig)
    [#31477](#31477)
- n-api:
  - add napi\_get\_all\_property\_names (himself65)
    [#30006](#30006)
  - add APIs for per-instance state management (Gabriel Schulhof)
    [#28682](#28682)
  - define release 6
    [#32058](#32058)
  - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen)
    [#26128](#26128)
- tls:
  - expose keylog event on TLSSocket (Alba Mendez)
    [#27654](#27654)
  - support TLS min/max protocol defaults in CLI (Sam Roberts)
    [#27946](#27946)
- url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig)
  [#26226](#26226)

PR-URL: #31984
BethGriggs added a commit that referenced this pull request Apr 7, 2020
macOS package notarization and a change in builder configuration

The macOS binaries for this release, and future 10.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing .pkg files on macOS
10.15 and later. Previous builds of Node.js 10.x were compiled on macOS
10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion).
As binaries are still being compiled to support a minimum of macOS 10.7
(Lion) we do not anticipate this having a negative impact on Node.js
10.x users with older versions of macOS.

Notable changes:

- buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc)
  [#19691](#19691)
- build: macOS package notarization (Rod Vagg)
  [#31459](#31459)
- deps:
  - update npm to 6.14.3 (Myles Borins)
    [#32368](#32368)
  - upgrade openssl sources to 1.1.1e (Hassaan Pasha)
    [#32328](#32328)
  - upgrade to libuv 1.34.2 (cjihrig)
    [#31477](#31477)
- n-api:
  - add napi\_get\_all\_property\_names (himself65)
    [#30006](#30006)
  - add APIs for per-instance state management (Gabriel Schulhof)
    [#28682](#28682)
  - define release 6
    [#32058](#32058)
  - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen)
    [#26128](#26128)
- tls:
  - expose keylog event on TLSSocket (Alba Mendez)
    [#27654](#27654)
  - support TLS min/max protocol defaults in CLI (Sam Roberts)
    [#27946](#27946)
- url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig)
  [#26226](#26226)

PR-URL: #31984
codebytere added a commit that referenced this pull request Apr 8, 2020
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
BethGriggs added a commit that referenced this pull request Apr 8, 2020
macOS package notarization and a change in builder configuration

The macOS binaries for this release, and future 10.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing .pkg files on macOS
10.15 and later. Previous builds of Node.js 10.x were compiled on macOS
10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion).
As binaries are still being compiled to support a minimum of macOS 10.7
(Lion) we do not anticipate this having a negative impact on Node.js
10.x users with older versions of macOS.

Notable changes:

- buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc)
  [#19691](#19691)
- build: macOS package notarization (Rod Vagg)
  [#31459](#31459)
- deps:
  - update npm to 6.14.3 (Myles Borins)
    [#32368](#32368)
  - upgrade openssl sources to 1.1.1e (Hassaan Pasha)
    [#32328](#32328)
  - upgrade to libuv 1.34.2 (cjihrig)
    [#31477](#31477)
- n-api:
  - add napi\_get\_all\_property\_names (himself65)
    [#30006](#30006)
  - add APIs for per-instance state management (Gabriel Schulhof)
    [#28682](#28682)
  - define release 6
    [#32058](#32058)
  - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen)
    [#26128](#26128)
- tls:
  - expose keylog event on TLSSocket (Alba Mendez)
    [#27654](#27654)
  - support TLS min/max protocol defaults in CLI (Sam Roberts)
    [#27946](#27946)
- url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig)
  [#26226](#26226)

PR-URL: #31984
BethGriggs added a commit that referenced this pull request Apr 8, 2020
macOS package notarization and a change in builder configuration

The macOS binaries for this release, and future 10.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing .pkg files on macOS
10.15 and later. Previous builds of Node.js 10.x were compiled on macOS
10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion).
As binaries are still being compiled to support a minimum of macOS 10.7
(Lion) we do not anticipate this having a negative impact on Node.js
10.x users with older versions of macOS.

Notable changes:

- buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc)
  [#19691](#19691)
- build: macOS package notarization (Rod Vagg)
  [#31459](#31459)
- deps:
  - update npm to 6.14.3 (Myles Borins)
    [#32368](#32368)
  - upgrade openssl sources to 1.1.1e (Hassaan Pasha)
    [#32328](#32328)
  - upgrade to libuv 1.34.2 (cjihrig)
    [#31477](#31477)
- n-api:
  - add napi\_get\_all\_property\_names (himself65)
    [#30006](#30006)
  - add APIs for per-instance state management (Gabriel Schulhof)
    [#28682](#28682)
  - define release 6
    [#32058](#32058)
  - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen)
    [#26128](#26128)
- tls:
  - expose keylog event on TLSSocket (Alba Mendez)
    [#27654](#27654)
  - support TLS min/max protocol defaults in CLI (Sam Roberts)
    [#27946](#27946)
- url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig)
  [#26226](#26226)

PR-URL: #31984
codebytere added a commit that referenced this pull request Apr 8, 2020
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
BethGriggs added a commit that referenced this pull request Apr 14, 2020
macOS package notarization and a change in builder configuration

The macOS binaries for this release, and future 10.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing .pkg files on macOS
10.15 and later. Previous builds of Node.js 10.x were compiled on macOS
10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion).
As binaries are still being compiled to support a minimum of macOS 10.7
(Lion) we do not anticipate this having a negative impact on Node.js
10.x users with older versions of macOS.

Notable changes:

- buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc)
  [#19691](#19691)
- build: macOS package notarization (Rod Vagg)
  [#31459](#31459)
- deps:
  - update npm to 6.14.3 (Myles Borins)
    [#32368](#32368)
  - upgrade openssl sources to 1.1.1e (Hassaan Pasha)
    [#32328](#32328)
  - upgrade to libuv 1.34.2 (cjihrig)
    [#31477](#31477)
- n-api:
  - add napi\_get\_all\_property\_names (himself65)
    [#30006](#30006)
  - add APIs for per-instance state management (Gabriel Schulhof)
    [#28682](#28682)
  - define release 6
    [#32058](#32058)
  - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen)
    [#26128](#26128)
- tls:
  - expose keylog event on TLSSocket (Alba Mendez)
    [#27654](#27654)
  - support TLS min/max protocol defaults in CLI (Sam Roberts)
    [#27946](#27946)
- url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig)
  [#26226](#26226)

PR-URL: #31984
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
Notable changes:

doc:
  * add ronag to collaborators (Robert Nagy) [#31498](#31498)
  * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](#31306)
deps:
  * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](#31304)
  * update openssl to 1.1.1e (Hassaan Pasha) [#32328](#32328)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

todo: update to openssl 1.1.1e on March 17th
9 participants