Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test-cluster-net-listen-ipv6only-* tests #32381

Merged
merged 2 commits into from
Mar 22, 2020
Merged

test: improve test-cluster-net-listen-ipv6only-* tests #32381

merged 2 commits into from
Mar 22, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 20, 2020 •
edited
Loading

  • Replace Map with Array
  • Add additional checks that code/test work as expected (Failed on Windows so I took it out.)
  • Use Promise.all() in place of countdown
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 20, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
BridgeAR
BridgeAR approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 20, 2020
@trivikr trivikr removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 21, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/29961/ ✔️

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2020
@Trott Trott mentioned this pull request Mar 21, 2020
Merged
2 tasks
@Trott
test: replace Map with Array in cluster-net-listen tests
7d4dedb 
PR-URL: nodejs#32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
test: replace countdown with Promise.all() in cluster-net-listen tests
ecfb7b0 
PR-URL: nodejs#32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member Author

Trott commented Mar 22, 2020

Landed in 1d49558...ecfb7b0

@Trott Trott merged commit ecfb7b0 into nodejs:master Mar 22, 2020
@Trott Trott deleted the seq-cluster branch March 22, 2020 04:53
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: replace Map with Array in cluster-net-listen tests
347f707 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: replace countdown with Promise.all() in cluster-net-listen tests
e2ee68e 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Mar 24, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: replace Map with Array in cluster-net-listen tests
bdcc11f 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: replace countdown with Promise.all() in cluster-net-listen tests
2e28783 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 22, 2020
@Trott @targos
test: replace Map with Array in cluster-net-listen tests
1b79174 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 22, 2020
@Trott @targos
test: replace countdown with Promise.all() in cluster-net-listen tests
97e352d 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @nodejs-github-bot @jasnell @addaleax @BridgeAR @trivikr