-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: drop Travis in favor of Actions #32450
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: build-windows | ||
|
||
on: [push, pull_request] | ||
|
||
env: | ||
PYTHON_VERSION: 3.8 | ||
FLAKY_TESTS: dontcare | ||
|
||
jobs: | ||
build-windows: | ||
runs-on: windows-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ env.PYTHON_VERSION }} | ||
uses: actions/setup-python@v1 | ||
with: | ||
PYTHON_VERSION: ${{ env.PYTHON_VERSION }} | ||
- name: Install deps | ||
run: choco install nasm | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Build | ||
run: ./vcbuild.bat |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
name: linters | ||
|
||
on: [push, pull_request] | ||
|
||
env: | ||
PYTHON_VERSION: 3.8 | ||
NODE_VERSION: 10.x | ||
|
||
jobs: | ||
lint-addon-docs: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ env.NODE_VERSION }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ env.NODE_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Lint addon docs | ||
run: NODE=$(which node) make lint-addon-docs | ||
lint-cpp: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ env.PYTHON_VERSION }} | ||
uses: actions/setup-python@v1 | ||
with: | ||
PYTHON_VERSION: ${{ env.PYTHON_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Lint C/C++ files | ||
run: make lint-cpp | ||
lint-md: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ env.NODE_VERSION }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ env.NODE_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Lint docs | ||
run: | | ||
echo "::add-matcher::.github/workflows/remark-lint-problem-matcher.json" | ||
NODE=$(which node) make lint-md | ||
lint-js: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ env.NODE_VERSION }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ env.NODE_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Lint JavaScript files | ||
run: NODE=$(which node) make lint-js | ||
lint-py: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ env.PYTHON_VERSION }} | ||
uses: actions/setup-python@v1 | ||
with: | ||
PYTHON_VERSION: ${{ env.PYTHON_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Lint Python | ||
run: | | ||
make lint-py-build || true | ||
NODE=$(which node) make lint lint-py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
name: misc | ||
|
||
on: [push, pull_request] | ||
|
||
env: | ||
NODE_VERSION: 12.x | ||
|
||
jobs: | ||
build-docs: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ env.NODE_VERSION }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ env.NODE_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Build | ||
run: NODE=$(which node) make doc-only | ||
- uses: actions/upload-artifact@v1 | ||
with: | ||
name: docs | ||
path: out/doc |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: test-linux | ||
|
||
on: [push, pull_request] | ||
|
||
env: | ||
PYTHON_VERSION: 3.8 | ||
FLAKY_TESTS: dontcare | ||
|
||
jobs: | ||
test-linux: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ env.PYTHON_VERSION }} | ||
uses: actions/setup-python@v1 | ||
with: | ||
PYTHON_VERSION: ${{ env.PYTHON_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Build | ||
run: make build-ci -j2 V=1 | ||
- name: Test | ||
run: make run-ci -j2 V=1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: test-macOS | ||
|
||
on: [push, pull_request] | ||
|
||
env: | ||
PYTHON_VERSION: 3.8 | ||
FLAKY_TESTS: dontcare | ||
|
||
jobs: | ||
test-macOS: | ||
runs-on: macos-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ env.PYTHON_VERSION }} | ||
uses: actions/setup-python@v1 | ||
with: | ||
PYTHON_VERSION: ${{ env.PYTHON_VERSION }} | ||
- name: Environment Information | ||
run: npx envinfo | ||
- name: Build | ||
run: make build-ci -j8 V=1 | ||
- name: Test | ||
run: make run-ci -j8 V=1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,6 @@ | |
!.gitkeep | ||
!.mailmap | ||
!.nycrc | ||
!.travis.yml | ||
!.eslintrc.yaml | ||
!.cpplint | ||
|
||
|
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since jenkins convers all platform test, maybe just test linux on github action is enough ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running on all three platforms gives authors an early signal on all Tier 1 platforms (
I could even argue that we should be testing ARM herenevermind, ARM is for self-hosted hosts only, which is a whole other conversation). This is less a matter of coverage (we're not covering anything extra with Travis or GitHub Actions today), but rather a matter of early feedback on an easier to consume interface for outside contributors (this was the goal when Travis was introduced at least).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add macOS, should we add windows test too ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, yes. I just didn't add because I have no idea how we test Windows on Jenkins (the commands I used on Linux and macOS came from Jenkins config, so they are more suited for CI environments).
If anyone knows the best way to run tests on Windows on CI, feel free to comment :)
There's always the option to add tests for Windows in a follow up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with Tier 1 platforms for now. Linux is actually the slowest platform on Actions for our build/tests (* may possibly change if we start running tests on Windows).
I'm also happy for tests to be added on Windows in a follow up PR (we're not running tests on Windows in Actions or Travis CI before this PR).