test: skip a wasi test on IBMi PASE #32459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't do what you think it does. You need to skip the test on IBMi from here. |
No, because the CI and users would need to have the WASI SDK installed to compile from |
The API clock_getres with attribute API CLOCK_THREAD_CPUTIME_ID is not supported on IBM i PASE.
richardlau
approved these changes
Mar 24, 2020
cjihrig
approved these changes
Mar 24, 2020
addaleax
added
the
author ready
addaleax
approved these changes
Mar 29, 2020
|
Landed in 4898c1d |
addaleax
pushed a commit
that referenced
this pull request
Mar 30, 2020
The API clock_getres with attribute API CLOCK_THREAD_CPUTIME_ID is not supported on IBM i PASE. PR-URL: #32459 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Mar 30, 2020
The API clock_getres with attribute API CLOCK_THREAD_CPUTIME_ID is not supported on IBM i PASE. PR-URL: #32459 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
The API clock_getres with attribute API CLOCK_THREAD_CPUTIME_ID is not supported on IBM i PASE. PR-URL: #32459 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API clock_getres with attribute API CLOCK_THREAD_CPUTIME_ID
is not supported on IBM i PASE.
This is the same change as V8 --> https://github.com/nodejs/node/blob/master/deps/v8/src/base/platform/time.cc#L73