Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: avoid using elevated v8 namespaces in headers #32468

Closed
wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 24, 2020

Just had a handful of using v8:... elevations in a couple of header files. This goes ahead and removes those.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 24, 2020
@jasnell jasnell force-pushed the cleanup-elevated-namespaces branch from 172efbb to 54f866b Compare March 24, 2020 21:02
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell jasnell force-pushed the cleanup-elevated-namespaces branch from 54f866b to 055c318 Compare March 24, 2020 21:02
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30035/ (:yellow_heart:)

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2020
@addaleax addaleax added the review wanted PRs that need reviews. label Mar 27, 2020
addaleax pushed a commit that referenced this pull request Apr 2, 2020
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #32468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Apr 2, 2020
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #32468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax
Copy link
Member

addaleax commented Apr 2, 2020

Landed in 23a3408...05da0bb

@addaleax addaleax closed this Apr 2, 2020
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #32468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #32468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 12, 2020
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #32468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 12, 2020
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #32468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos added backport-blocked-v12.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x review wanted PRs that need reviews. labels Apr 22, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#32468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#32468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 28, 2020
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #32468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 28, 2020
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #32468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants