Revert "test: mark empty udp tests flaky on OS X"

[lpinca]

This reverts commit 24a4f76.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[lpinca]

The issue seems to be fixed in macOS 10.15.4

[lpinca]

@nodejs/platform-macos @AshCripps

[sam-github]

Are these the tests that just failed in https://ci.nodejs.org/job/node-test-commit-osx/32914/#showFailuresLink from the unrelated to UDP #32207 ?

If so, they are still flaky.

[lpinca]

Yes, what is the macOS version on jenkins?

[lpinca]

It seems to be 10.15.1, can it be updated to 10.15.4?

[AshCripps]

The macs should be able to be updated, might be a bit disruptive.

This PR should be held off until the machines are updated.

[lpinca]

Added blocked label.

[AshCripps]

https://ci.nodejs.org/job/node-test-commit-osx-AshCripps/10/nodes=test-nearform-macos10.15-x64-1/ passed with 10.15.4 but test.sequential/test-timers-blocking-callback failed again.

Now working on the other two machines

[AshCripps]

@lpinca All 1015 macs currently in CI are now 10.15.4 feel free to remove the blocked label

[AshCripps]

Will also need to be reverted on 12.x I believe

[lpinca]

Done, thank you.

[richardlau]

As of #32450 we're now testing on macOS with GitHub Actions and as far as I can tell the macOS runners are still macOS 10.15.3.

[lpinca]

@richardlau it looks like tests marked as flaky are run, see https://github.com/nodejs/node/pull/32534/checks?check_run_id=541357985 so we should either unblock this or set FLAKY_TESTS to skip.

[lpinca]

Nvm it's already set to dontcare.

[richardlau]

We’ll still need to keep the tests marked as FLAKY (e.g. this is blocked) for either FLAKY_TESTS skip or dontcare.

[lpinca]

Removed "blocked" again as macOS runners now use 10.15.4

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/30404/

[lpinca]

Landed in f675e3a.