Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify docs fs.watch exception may be emitted #32513

Closed
wants to merge 3 commits into from
Closed

doc: clarify docs fs.watch exception may be emitted #32513

wants to merge 3 commits into from

Conversation

juanarbol
Copy link
Member

@juanarbol juanarbol commented Mar 27, 2020 •
edited
Loading

Fixes: #29894

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Mar 27, 2020
jasnell
jasnell reviewed Mar 27, 2020
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Mar 31, 2020
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Mar 31, 2020
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Mar 31, 2020
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 2, 2020
addaleax pushed a commit that referenced this pull request Apr 5, 2020
@juanarbol @addaleax
doc: clarify docs fs.watch exception may be emitted
34a4ab7 
Fixes: #29894

PR-URL: #32513
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@addaleax
Copy link
Member

addaleax commented Apr 5, 2020

Landed in 34a4ab7

@addaleax addaleax closed this Apr 5, 2020
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@juanarbol @BethGriggs
doc: clarify docs fs.watch exception may be emitted
49c1506 
Fixes: #29894

PR-URL: #32513
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
@juanarbol @targos
doc: clarify docs fs.watch exception may be emitted
5c70db4 
Fixes: #29894

PR-URL: #32513
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@juanarbol @targos
doc: clarify docs fs.watch exception may be emitted
21c3685 
Fixes: #29894

PR-URL: #32513
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
@juanarbol juanarbol deleted the juanarbol/fix-29894 branch January 19, 2021 16:25
@Dmarch28 Dmarch28 mentioned this pull request Jun 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 19, 2022
Open
@137717unity 137717unity mentioned this pull request Jun 19, 2022
Open
@baby636 baby636 mentioned this pull request Jun 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 19, 2022
Open
@kissofire kissofire mentioned this pull request Jun 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 19, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Jun 19, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Jun 20, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Jan 30, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Jan 31, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 31, 2023
Open
@baby636 baby636 mentioned this pull request Jan 31, 2023
Open
This was referenced Jan 31, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@jasnell jasnell jasnell left review comments

@trivikr trivikr trivikr approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fs.isWatchAvailable() [capabilities check for fs.watch()]
6 participants
@juanarbol @addaleax @jasnell @Trott @trivikr @nodejs-github-bot