test: refactor test-http2-buffersize #32540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Mar 29, 2020
Trott
added
the
author ready
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell
reviewed
Mar 29, 2020
Trott
force-pushed
the
refac-http2-bufsize
branch
from
aaa58cf
to
acdfa56
Compare
This comment has been minimized.
This comment has been minimized.
Remove seemlingly misplaced and/or extraneous comment. Replace countdown with Promise.all. PR-URL: nodejs#32540 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Trott
force-pushed
the
refac-http2-bufsize
branch
from
acdfa56
to
c452632
Compare
|
Landed in c452632 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
Remove seemlingly misplaced and/or extraneous comment. Replace countdown with Promise.all. PR-URL: #32540 Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
Remove seemlingly misplaced and/or extraneous comment. Replace countdown with Promise.all. PR-URL: #32540 Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Remove seemlingly misplaced and/or extraneous comment. Replace countdown with Promise.all. PR-URL: #32540 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove seemlingly misplaced and/or extraneous comment. Replace countdown
with Promise.all.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes