worker: do not emit 'exit' events during process.exit() #32546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not emit `'exit'` events caused by recursively stopping all running Workers from inside the `process.exit()` call.
nodejs-github-bot
added
the
c++
4 tasks
gireeshpunathil
approved these changes
Mar 29, 2020
|
CI: https://ci.nodejs.org/job/node-test-pull-request/30167/ (:heavy_check_mark:) |
jasnell
approved these changes
Mar 29, 2020
addaleax
added
the
author ready
cjihrig
approved these changes
Mar 29, 2020
addaleax
added a commit
that referenced
this pull request
Apr 2, 2020
Do not emit `'exit'` events caused by recursively stopping all running Workers from inside the `process.exit()` call. PR-URL: #32546 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 8b9e877 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
Do not emit `'exit'` events caused by recursively stopping all running Workers from inside the `process.exit()` call. PR-URL: #32546 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
Do not emit `'exit'` events caused by recursively stopping all running Workers from inside the `process.exit()` call. PR-URL: #32546 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Do not emit `'exit'` events caused by recursively stopping all running Workers from inside the `process.exit()` call. PR-URL: #32546 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
This cherry picks cleanly onto v10.x-staging but the test fails, probably because workers in 10.x are experimental and require a flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not emit
'exit'events caused by recursively stopping allrunning Workers from inside the
process.exit()call.(Split out from #32531 as this is semver-patch and should definitely be backported to LTS.)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes