Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing changes: entry for dns.ALL #32617

Closed
wants to merge 1 commit into from
Closed

doc: add missing changes: entry for dns.ALL #32617

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Apr 2, 2020

Refs: #32183

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. labels Apr 2, 2020
@addaleax addaleax mentioned this pull request Apr 2, 2020
Closed
4 tasks
@addaleax
Copy link
Member Author

addaleax commented Apr 2, 2020

Please 👍 this comment to approve fast-tracking

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 2, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 2, 2020
@addaleax
Copy link
Member Author

addaleax commented Apr 2, 2020

Landed in 5661121

addaleax added a commit that referenced this pull request Apr 2, 2020
@addaleax
doc: add missing changes: entry for dns.ALL
5661121 
Refs: #32183

PR-URL: #32617
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax closed this Apr 2, 2020
@addaleax addaleax deleted the dns-ai-all-added branch April 2, 2020 23:06
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@addaleax @BethGriggs
doc: add missing changes: entry for dns.ALL
1bec3ac 
Refs: #32183

PR-URL: #32617
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
@addaleax @targos
doc: add missing changes: entry for dns.ALL
3296359 
Refs: #32183

PR-URL: #32617
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Apr 13, 2020
Merged
@targos targos added backport-blocked-v12.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 22, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@addaleax @targos
doc: add missing changes: entry for dns.ALL
b21e792 
Refs: nodejs#32183

PR-URL: nodejs#32617
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@addaleax @targos
doc: add missing changes: entry for dns.ALL
a55d215 
Refs: #32183

PR-URL: #32617
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @lpinca @cjihrig @targos @nodejs-github-bot