Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: sync access for report and openssl options #32618

Closed
wants to merge 1 commit into from
Closed

src: sync access for report and openssl options #32618

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

Audited usage of per-process OpenSSL and Report options, adding two
required mutexes.

Also documented existence and typical use of the per-process cli option
mutex.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Apr 2, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 2, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30396/

@sam-github sam-github mentioned this pull request Apr 3, 2020
Merged
3 tasks
@gireeshpunathil
Copy link
Member

(Outside of this PR, but because we are here) does it makes sense to have an internal document which contain:

  • shared data
  • different locks that are used
  • lock ordering constraints if any

@codecov-io
Copy link

codecov-io commented Apr 3, 2020 •
edited
Loading

Codecov Report

Merging #32618 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #32618   +/-   ##
=======================================
  Coverage   97.54%   97.55%           
=======================================
  Files         195      195           
  Lines       65834    65811   -23     
=======================================
- Hits        64218    64201   -17     
+ Misses       1616     1610    -6
Impacted Files Coverage Δ
lib/_stream_writable.js 99.03% <0.00%> (-0.01%) ⬇️
lib/_stream_readable.js 98.56% <0.00%> (-0.01%) ⬇️
lib/internal/http2/core.js 96.92% <0.00%> (+0.05%) ⬆️
lib/internal/util/inspect.js 100.00% <0.00%> (+0.09%) ⬆️
lib/internal/stream_base_commons.js 98.57% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e6d24...80bf18b. Read the comment docs.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30468/

@sam-github
src: sync access for report and openssl options
80bf18b 
Audited usage of per-process OpenSSL and Report options, adding two
required mutexes.

Also documented existence and typical use of the per-process cli option
mutex.
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30491/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30542/

addaleax pushed a commit that referenced this pull request Apr 8, 2020
@sam-github @addaleax
src: sync access for report and openssl options
fcde1de 
Audited usage of per-process OpenSSL and Report options, adding two
required mutexes.

Also documented existence and typical use of the per-process cli option
mutex.

PR-URL: #32618
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@addaleax
Copy link
Member

addaleax commented Apr 8, 2020

Landed in fcde1de

@addaleax addaleax closed this Apr 8, 2020
targos pushed a commit that referenced this pull request Apr 12, 2020
@sam-github @targos
src: sync access for report and openssl options
1763649 
Audited usage of per-process OpenSSL and Report options, adding two
required mutexes.

Also documented existence and typical use of the per-process cli option
mutex.

PR-URL: #32618
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos targos mentioned this pull request Apr 13, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@sam-github @BethGriggs
src: sync access for report and openssl options
8ce52f9 
Audited usage of per-process OpenSSL and Report options, adding two
required mutexes.

Also documented existence and typical use of the per-process cli option
mutex.

PR-URL: #32618
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@sam-github sam-github mentioned this pull request Apr 22, 2020
Closed
4 tasks
@targos targos removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@sam-github @targos
src: sync access for report and openssl options
22e8114 
Audited usage of per-process OpenSSL and Report options, adding two
required mutexes.

Also documented existence and typical use of the per-process cli option
mutex.

PR-URL: nodejs#32618
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@sam-github @targos
src: sync access for report and openssl options
c0d3fc2 
Audited usage of per-process OpenSSL and Report options, adding two
required mutexes.

Also documented existence and typical use of the per-process cli option
mutex.

PR-URL: #32618
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos targos mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sam-github @nodejs-github-bot @gireeshpunathil @codecov-io @addaleax @jasnell @cjihrig @targos