lib: removes unused params #32694
Closed
lib: removes unused params #32694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
fs
addaleax
approved these changes
Apr 6, 2020
cjihrig
approved these changes
Apr 6, 2020
jasnell
approved these changes
Apr 7, 2020
Flarna
approved these changes
Apr 7, 2020
lpinca
approved these changes
Apr 7, 2020
himself65
approved these changes
Apr 10, 2020
himself65
added
the
author ready
himself65
pushed a commit
to himself65/node
that referenced
this pull request
Apr 10, 2020
PR-URL: nodejs#32694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
|
Landed in 4076e04 Thanks for your contributions!🎉 |
|
The code change here is fine, but the commit message isn't very informative. Adding in the one-sentence description from the PR would have been an easy and significant improvement, as would have changing the subsystem from |
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
PR-URL: #32694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 14, 2020
PR-URL: #32694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
PR-URL: #32694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
optionsparams fromreadSyncandwriteFileHandlefunctions as it's never used within them.make -j4 test(UNIX), orvcbuild test(Windows) passes