build: output dots instead of tap in GitHub actions #32714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the output much smaller and lets us focus on errors if there are any.
nodejs-github-bot
added
build
Trott
approved these changes
Apr 8, 2020
richardlau
reviewed
Apr 8, 2020
richardlau
approved these changes
Apr 8, 2020
cjihrig
approved these changes
Apr 8, 2020
Trott
added
the
author ready
trivikr
approved these changes
Apr 11, 2020
targos
added a commit
that referenced
this pull request
Apr 12, 2020
This makes the output much smaller and lets us focus on errors if there are any. PR-URL: #32714 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in 57aba5e |
targos
added a commit
that referenced
this pull request
Apr 13, 2020
This makes the output much smaller and lets us focus on errors if there are any. PR-URL: #32714 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 14, 2020
This makes the output much smaller and lets us focus on errors if there are any. PR-URL: #32714 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
added a commit
that referenced
this pull request
Apr 22, 2020
This makes the output much smaller and lets us focus on errors if there are any. PR-URL: #32714 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the output much smaller and lets us focus on errors if there
are any.
Otherwise, the UI becomes too slow and prevents navigating in the test output. The output is still too long IMO but this reduces it significantly
I'm open to alternative ways to pass that option to the test runner.