Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: move doc versions JSON file out of out/doc #32728

Merged
merged 1 commit into from
Apr 11, 2020
Merged

build: move doc versions JSON file out of out/doc #32728

merged 1 commit into from
Apr 11, 2020

Conversation

richardlau
Copy link
Member

Move the generated previous doc versions JSON file out of out/doc to
prevent it being included in the distributed packages.

Fixes: nodejs/build#2276

cc @codebytere

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 8, 2020
@richardlau richardlau mentioned this pull request Apr 8, 2020
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30572/

@codebytere codebytere mentioned this pull request Apr 8, 2020
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 9, 2020 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/30593/ (✅)

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2020
@richardlau
build: move doc versions JSON file out of out/doc
ce21749 
Move the generated previous doc versions JSON file out of `out/doc` to
prevent it being included in the distributed packages.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: nodejs#32728
Fixes: nodejs/build#2276
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlau richardlau merged commit ce21749 into nodejs:master Apr 11, 2020
@richardlau
Copy link
Member Author

Landed in ce21749.

@richardlau richardlau deleted the doccache branch April 11, 2020 11:08
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2020
Merged
targos pushed a commit that referenced this pull request Apr 13, 2020
@richardlau @targos
build: move doc versions JSON file out of out/doc
f9a2276 
Move the generated previous doc versions JSON file out of `out/doc` to
prevent it being included in the distributed packages.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32728
Fixes: nodejs/build#2276
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targos targos mentioned this pull request Apr 13, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@richardlau @BethGriggs
build: move doc versions JSON file out of out/doc
3c4d1f6 
Move the generated previous doc versions JSON file out of `out/doc` to
prevent it being included in the distributed packages.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32728
Fixes: nodejs/build#2276
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
richardlau added a commit that referenced this pull request Apr 17, 2020
@richardlau
build: move doc versions JSON file out of out/doc
a85721a 
Move the generated previous doc versions JSON file out of `out/doc` to
prevent it being included in the distributed packages.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32728
Fixes: nodejs/build#2276
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
@richardlau @targos
build: move doc versions JSON file out of out/doc
c98aa93 
Move the generated previous doc versions JSON file out of `out/doc` to
prevent it being included in the distributed packages.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32728
Fixes: nodejs/build#2276
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Jun 2, 2020
@richardlau @BethGriggs
build: move doc versions JSON file out of out/doc
145dcc2 
Move the generated previous doc versions JSON file out of `out/doc` to
prevent it being included in the distributed packages.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32728
Fixes: nodejs/build#2276
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlau richardlau mentioned this pull request Jul 2, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@codebytere codebytere codebytere approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v12.x LTS expected assets need updating
6 participants
@richardlau @nodejs-github-bot @Trott @lpinca @codebytere @gengjiawen