2020-04-12 Node.js v10.20.1 'Dubnium' (LTS) Release #32768
Conversation
nodejs-github-bot
added
meta
Notable changes: Due to release process failures, Node.js v10.20.0 shipped with source and header tarballs that did not properly match the final release commit that was used to build the binaries. We recommend that Node.js v10.20.0 not be used, particularly in any applications using native add-ons or where compiling Node.js from source is involved. Node.js v10.20.1 is a clean release with the correct sources and is strongly recommended in place of v10.20.0. PR-URL: #32768
BethGriggs
force-pushed
the
v10.20.1-proposal
branch
from
5869079 to
d2c12b7
Compare
|
Kicking off a build now - I think it makes sense break the 'avoid Friday releases' rule here if the build will complete in time. |
|
plinux is failing CI with: 18:13:08 WARNING: failed to autodetect C++ compiler version (CXX=g++-4.9)
18:13:08 WARNING: failed to autodetect C compiler version (CC=gcc-4.9)
18:13:08 ERROR: No acceptable C compiler found!
18:13:08
18:13:08 Please make sure you have a C compiler installed on your system and/or
18:13:08 consider adjusting the CC environment variable if you installed
18:13:08 it in a non-standard prefix.
18:13:08 make: *** [build-ci] Error 1@sam-github @nodejs/build |
|
@BethGriggs I'd just ignore that and start the release job |
|
@targos, I just checked and the release machine is failing with Edit: link - https://ci-release.nodejs.org/job/iojs+release/nodes=centos7-ppcle-release-64/5885/console 19:34:07 make[2]: g++-4.9: Command not found
19:34:07 make[2]: *** [/home/iojs/build/ws/out/Release/torque] Error 127
19:34:07 make[2]: *** Waiting for unfinished jobs....
19:34:07 rm dc0aa0889910e117de695888bc7126f9a7a14634.intermediate
19:34:07 make[2]: Leaving directory `/home/iojs/build/ws/out'
19:34:07 make[1]: *** [node] Error 2
19:34:07 make[1]: Leaving directory `/home/iojs/build/ws' |
|
@sam-github this could be related to the recent devtoolset changes? |
|
All other release builds look good ✅ I don't think it's likely (or a reasonable expectation) that we'll get the machines fixed up on a public holiday. I'll keep checking back in over this evening and the weekend to see if anything has changed. Otherwise, Monday is looking more likely. EDIT: nodejs/build#2282 needs to land first also. |
|
nodejs/build#2285 should fix compiler selection on pLinux. cc @nodejs/build |
|
nodejs/build#2285 landed, hope it'll fix this, thanks for the PR @richardlau |
|
I can confirm the PR fixed the issue and ppcle builds are complete. Thanks @richardlau, @sam-github (nodejs/build#2282 still in progress) |
|
It looks like this will not be ready to promote today UTC. I can check back over the weekend but it may make sense to leave it until Monday. @nodejs/releasers (and any others with an opinion) thoughts on pushing this out, if possible:
|
BethGriggs
force-pushed
the
v10.20.1-proposal
branch
from
d2c12b7 to
eef4251
Compare
Notable changes: Due to release process failures, Node.js v10.20.0 shipped with source and header tarballs that did not properly match the final release commit that was used to build the binaries. We recommend that Node.js v10.20.0 not be used, particularly in any applications using native add-ons or where compiling Node.js from source is involved. Node.js v10.20.1 is a clean release with the correct sources and is strongly recommended in place of v10.20.0. PR-URL: #32768
BethGriggs
force-pushed
the
v10.20.1-proposal
branch
from
eef4251 to
f08441e
Compare
2020-04-10, Version 10.20.1 'Dubnium' (LTS), @BethGriggs
Notable changes
Due to release process failures, Node.js v10.20.0 shipped with source
and header tarballs that did not properly match the final release
commit that was used to build the binaries. We recommend that Node.js
v10.20.0 not be used, particularly in any applications using native
add-ons or where compiling Node.js from source is involved.
Node.js v10.20.1 is a clean release with the correct sources and is
strongly recommended in place of v10.20.0.
Refs: #32755