Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: return this from IncomingMessage#destroy() #32789

Merged
merged 3 commits into from
May 9, 2020
Merged

http: return this from IncomingMessage#destroy() #32789

merged 3 commits into from
May 9, 2020

Commits on May 9, 2020

  1. http: return this from IncomingMessage#destroy() 

    This commit updates IncomingMessage#destroy() to return `this`
for consistency with other readable streams.

PR-URL: nodejs#32789
Fixes: nodejs#32772
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @cjihrig
    cjihrig committed May 9, 2020
    Configuration menu
    Copy the full SHA
    ff6535a View commit details
    Browse the repository at this point in the history

  2. http: return this from ClientRequest#destroy() 

    This commit updates ClientRequest#destroy() to return `this`
for consistency with other writable streams.

PR-URL: nodejs#32789
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @cjihrig
    cjihrig committed May 9, 2020
    Configuration menu
    Copy the full SHA
    cad76da View commit details
    Browse the repository at this point in the history

  3. http: return this from OutgoingMessage#destroy() 

    This commit updates OutgoingMessage#destroy() to return `this`
for consistency with other writable streams.

PR-URL: nodejs#32789
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @cjihrig
    cjihrig committed May 9, 2020
    Configuration menu
    Copy the full SHA
    94e5b5c View commit details
    Browse the repository at this point in the history