build: Intl: deps: bump ICU to 56.1 (GA) #3281

srl295 · 2015-10-08T15:25:24Z

ICU 56 was just released yesterday. Update to it.
Notable changes: Unicode 8, CLDR 28, 2-3x number format perf,
20% improvement in Collator startup
- more at http://site.icu-project.org/download/56 or in Intl: ICU 55 to 56 bump #2917

@jasnell if you can land this in master also it would be great otherwise I will do later

srl295 · 2015-10-08T15:26:21Z

test running https://ci.nodejs.org/job/node-test-pull-request/454/console
Note: i haven't mirrored the ICU url to our CDN yet. Hopefully server won't melt before I get a round tuit.

jasnell · 2015-10-08T15:47:48Z

One challenge in the CI build: "ok 469 test-intl.js # skip Intl tests because Intl object not present." ... it doesn't look like our CI is configured with --with-intl enabled (/cc @nodejs/build)

jasnell · 2015-10-08T16:03:27Z

@srl295 ... getting compile erros when attempting to run a build locally on Mac OS X 10.11

clang: error: clangno such file or directory: '../deps/icu/source/tools/genrb/reslist.c': 
error: no such file or directory: '../deps/icu/source/tools/genrb/genrb.c'clang: error
: no input files
clang: error: no input files
  g++ '-D_DARWIN_USE_64_BIT_INODE=1' '-DUCONFIG_NO_TRANSLITERATION=1' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' '-DUCONFIG_NO_LEGACY_CONVERSION=1' '-DUCONFIG_NO_IDNA=1' -I../deps/icu/source/common -I../deps/icu/source/i18n -I../deps/icu/source/io -I../deps/icu/source/tools/toolutil  -Os -gdwarf-2 -mmacosx-version-min=10.5 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++0x -fno-rtti -fno-exceptions -fno-thre:clang: error: no such file or directory: '../deps/icu/source/tools/genrb/wrtjava.c'
clang: error: no input files
make[1]: *** [/Users/james/Node/main/node/out/Release/obj.host/genrb/deps/icu/source/tools/genrb/wrtjava.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [/Users/james/Node/main/node/out/Release/obj.host/genrb/deps/icu/source/tools/genrb/genrb.o] Error 1
make[1]: *** [/Users/james/Node/main/node/out/Release/obj.host/genrb/deps/icu/source/tools/genrb/reslist.o] Error 1
../deps/icu/source/tools/genrb/wrtxml.cpp:397:1: warning: unused function 'print' [-Wunused-function]
print(UChar* src, int32_t srcLen,const char *tagStart,const char *tagEnd,  UErrorCode *status){
^
../deps/icu/source/tools/genrb/wrtxml.cpp:472:13: warning: unused function 'printAttribute' [-Wunused-function]
static void printAttribute(const char *name, const UnicodeString value, int32_t /*len*/)
            ^
../tools/icu/iculslocs.cc:196:15: warning: unused variable 'isTable' [-Wunused-variable]
  const UBool isTable = (UBool)(ures_getType(bund.getAlias()) == URES_TABLE);
              ^
1 warning generated.
2 warnings generated.
make: *** [node] Error 2

srl295 · 2015-10-08T16:31:07Z

no such file ... genrb.c
@jasnell I think the above is due to one of the generated makefiles not being removed cleanly. In 56 that file is genrb.cpp.

jasnell · 2015-10-08T16:39:49Z

Ok, that's what I was figuring. I've removed the out directory manually and kicked off another build. I'll let you know how it goes. Can you please investigate to see if additional ICU cleanups need to be done by make clean?

I hesitate to land this yet because not everyone is going to build from a clean branch. The cleanup of the old deps/icu, icu zip and make files could trip others up. Ideally, make clean would fully reset and/or configure would catch that deps/icu and the icu zip are out of date and prepare accordingly

srl295 · 2015-10-08T16:57:06Z

@jasnell okay, the offending file is: node/out/Release/.deps//home/srl/src/node/out/Release/obj.host/genrb/deps/icu/source/tools/genrb/genrb.o.d

Why doesn't make clean delete this? Looks like it only deletes *.o files. I assumed I was just doing it wrong™.

Should make clean deleting the .deps dir? For that matter should configure delete it?

jasnell · 2015-10-08T16:58:13Z

No objection from me. @nodejs/build @rvagg ... any opinions?

Fishrock123 · 2015-10-08T17:01:38Z

https -- yes please!

srl295 · 2015-10-08T17:02:29Z

@Fishrock123

https

Thanks for noticing. I had meant to do that before.

* ICU 56 was just released yesterday. Update to it. * Notable changes: Unicode 8, CLDR 28, 2-3x number format perf, 20% improvement in Collator startup * more at http://site.icu-project.org/download/56 or in nodejs#2917 Also: * cleanup out/**/*.d and deps/icu on "make clean" Fixes: nodejs#2917

srl295 · 2015-10-08T17:20:19Z

updated pr so make check deletes out/…/*.d and also deps/icu … (a notice is printed if deps/icu was removed)

jasnell · 2015-10-08T17:53:35Z

Ok, updated PR LGTM on OS X. Will spin up a windows test run shortly

jasnell · 2015-10-08T20:53:33Z

On windows, vcbuild.bat clean needs to be updated to remove the deps/icu directory. Other than that, build looks good. Once the PR is updated with the vcbuild changes, I'll do one more test pass then get it landed.

jasnell · 2015-10-08T21:14:03Z

LGTM! @mhdawson ... I'll be getting this landed in master... do you want to do some testing before I pull it into v4.x?

* ICU 56 was just released yesterday. Update to it. * Notable changes: Unicode 8, CLDR 28, 2-3x number format perf, 20% improvement in Collator startup * more at http://site.icu-project.org/download/56 or in #2917 Also: * cleanup out/**/*.d and deps/icu on "make clean" * cleanup deps/icu on "vcbuild clean" When building from an non-clean directory, it's important to run `make clean` or `vcbuild clean` to remove the existing ICU 55 from the deps path before building. Fixes: #2917 PR-URL: #3281 Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell · 2015-10-08T21:23:37Z

Landed in 01908d0. Still need to land on v4.x

* ICU 56 was just released yesterday. Update to it. * Notable changes: Unicode 8, CLDR 28, 2-3x number format perf, 20% improvement in Collator startup * more at http://site.icu-project.org/download/56 or in #2917 Also: * cleanup out/**/*.d and deps/icu on "make clean" * cleanup deps/icu on "vcbuild clean" When building from an non-clean directory, it's important to run `make clean` or `vcbuild clean` to remove the existing ICU 55 from the deps path before building. Fixes: #2917 PR-URL: #3281 Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell · 2015-10-09T00:15:20Z

Landed in v4.x with af24376

The first Node.js LTS release! See https://github.com/nodejs/LTS/ for details of the LTS process. * **icu**: Updated to version 56 with significant performance improvements (Steven R. Loomis) #3281 * **node**: - Added new `-c` (or `--check`) command line argument for checking script syntax without executing the code (Dave Eddy) #2411 - Added `process.versions.icu` to hold the current ICU library version (Evan Lucas) #3102 - Added `process.release.lts` to hold the current LTS codename when the binary is from an active LTS release line (Rod Vagg) #3212 * **npm**: Upgraded to npm 2.14.7 from 2.14.4, see release notes: https://github.com/npm/npm/releases/tag/v2.14.7 for full details (Kat Marchán) #3299 PR-URL: #3258

srl295 added the land-on-v4.x label Oct 8, 2015

srl295 self-assigned this Oct 8, 2015

mscdex added build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. labels Oct 8, 2015

srl295 force-pushed the srl295-icu56-2917 branch from 1d2a2b8 to b7229bb Compare October 8, 2015 17:18

add vcbuild clean'

2d6e0d3

srl295 closed this Oct 8, 2015

srl295 deleted the srl295-icu56-2917 branch October 8, 2015 22:02

jasnell added the lts-landed-on-v4.x label Oct 9, 2015

jasnell mentioned this pull request Oct 9, 2015

Release proposal: v4.2.0 'Argon' (LTS) #3258

Closed

MylesBorins removed the land-on-v4.x label Nov 17, 2015

srl295 mentioned this pull request Feb 15, 2016

build fails when --with-intl=small-icu with ICU 56.1 #5249

Closed

srl295 mentioned this pull request Nov 10, 2017

Need to update source exclusions for ICU 61 #16937

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: Intl: deps: bump ICU to 56.1 (GA) #3281

build: Intl: deps: bump ICU to 56.1 (GA) #3281

srl295 commented Oct 8, 2015

srl295 commented Oct 8, 2015

jasnell commented Oct 8, 2015

jasnell commented Oct 8, 2015

srl295 commented Oct 8, 2015

jasnell commented Oct 8, 2015

srl295 commented Oct 8, 2015

jasnell commented Oct 8, 2015

Fishrock123 commented Oct 8, 2015

srl295 commented Oct 8, 2015

srl295 commented Oct 8, 2015

jasnell commented Oct 8, 2015

jasnell commented Oct 8, 2015

jasnell commented Oct 8, 2015

jasnell commented Oct 8, 2015

jasnell commented Oct 9, 2015

build: Intl: deps: bump ICU to 56.1 (GA) #3281

build: Intl: deps: bump ICU to 56.1 (GA) #3281

Conversation

srl295 commented Oct 8, 2015

srl295 commented Oct 8, 2015

jasnell commented Oct 8, 2015

jasnell commented Oct 8, 2015

srl295 commented Oct 8, 2015

jasnell commented Oct 8, 2015

srl295 commented Oct 8, 2015

jasnell commented Oct 8, 2015

Fishrock123 commented Oct 8, 2015

srl295 commented Oct 8, 2015

srl295 commented Oct 8, 2015

jasnell commented Oct 8, 2015

jasnell commented Oct 8, 2015

jasnell commented Oct 8, 2015

jasnell commented Oct 8, 2015

jasnell commented Oct 9, 2015