Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: coerce -0 into 0 for process APIs #32841

Closed
wants to merge 2 commits into from

Conversation

HarshithaKP
Copy link
Member

Fixes: #32750

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@HarshithaKP
Copy link
Member Author

/test/known_issues/test-crypto-authenticated-stream.js is failing with timeout. Running it a 100 times to see if it is related to my changes.

Trott
Trott previously requested changes Apr 14, 2020
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test, I would think.

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true that this would fix #32750 but as I noted there, this is a general issue and I would like that we fix it in a general way.

@HarshithaKP
Copy link
Member Author

@Trott, added a scenario in test-process-uid-gid.js, PTAL

@HarshithaKP
Copy link
Member Author

@targos, I believe it is generic already (covering more APIs that setuid), do you have any better suggestions?

@addaleax
Copy link
Member

@HarshithaKP I think the most reasonable thing is to go through the C++ source code, and check it for usages of IsUint32. For those cases where it’s possible that -0 gets passed, there is probably some ….As<Uint32>()->Value() usage, which could be replaced with ->Uint32Value(context).To(…) (like here).

@Trott Trott dismissed their stale review April 15, 2020 02:37

test added

@BridgeAR
Copy link
Member

Ping @HarshithaKP

@HarshithaKP
Copy link
Member Author

@BridgeAR , I tried to implement the suggested approach, but got into issues.

@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:18
@targos targos added the process Issues and PRs related to the process subsystem. label Dec 27, 2020
@jasnell jasnell added the stalled Issues and PRs that are stalled. label Jan 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2021

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

@HarshithaKP
Copy link
Member Author

Intention fulfilled in #36786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Issues and PRs related to the process subsystem. stalled Issues and PRs that are stalled.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

process.setuid results in an abort
7 participants