-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: coerce -0
into 0
for process APIs
#32841
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a test, I would think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Trott, added a scenario in |
@targos, I believe it is generic already (covering more APIs that setuid), do you have any better suggestions? |
@HarshithaKP I think the most reasonable thing is to go through the C++ source code, and check it for usages of |
Ping @HarshithaKP |
@BridgeAR , I tried to implement the suggested approach, but got into issues. |
8ae28ff
to
2935f72
Compare
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
Intention fulfilled in #36786 |
Fixes: #32750
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes