Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix handling generators in Readable.from #32844

Closed
wants to merge 11 commits into from
Closed

stream: fix handling generators in Readable.from #32844

wants to merge 11 commits into from

Commits on Apr 15, 2020

  1. stream: close iterator in Readable.from 

    Call iterator.return() if not all of its values are consumed.

Fixes: nodejs#32842
    @vadzim
    vadzim committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    2fa5848 View commit details
    Browse the repository at this point in the history

  2. fixup: explicit yielded event in closeStreamWhileNextIsPending

    @vadzim
    vadzim committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    980a7c8 View commit details
    Browse the repository at this point in the history

  3. fixup: test fot iterator closing after null has been yielded

    @vadzim
    vadzim committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    b772927 View commit details
    Browse the repository at this point in the history

  4. fixup: escape unhandled rejected promise

    @vadzim
    vadzim committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    57bb126 View commit details
    Browse the repository at this point in the history

  5. fixup: test for closing iterator on yielded null 

    with plain event handling
    @vadzim
    vadzim committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    8a2974f View commit details
    Browse the repository at this point in the history

  6. fixup: fix variable name

    @vadzim
    vadzim committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    8528ad4 View commit details
    Browse the repository at this point in the history

  7. fixup: run callback with process.nextTick

    @vadzim
    vadzim committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    e821b98 View commit details
    Browse the repository at this point in the history

  8. remove unnesessary closure

    @vadzim
    vadzim committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    e9becca View commit details
    Browse the repository at this point in the history

  9. fixup: do not doublecheck needToClose flag

    @vadzim
    vadzim committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    509be2c View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2020

  1. fixup: make _destroy not async

    @vadzim
    vadzim committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    7aac752 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. fixup: trigger build

    @vadzim
    vadzim committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    bffbf58 View commit details
    Browse the repository at this point in the history