Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix null deref in AllocatedBuffer::clear #32892

Closed
wants to merge 1 commit into from
Closed

src: fix null deref in AllocatedBuffer::clear #32892

wants to merge 1 commit into from

Conversation

fowles
Copy link
Contributor

@fowles fowles commented Apr 16, 2020

An empty buffer can have a null environment. Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@fowles
src: fix null deref in AllocatedBuffer::clear
49f8f01 
An empty buffer can have a null environment.  Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 16, 2020
@fowles
Copy link
Contributor Author

fowles commented Apr 16, 2020

@soldair FYI

@fowles fowles mentioned this pull request Apr 16, 2020
Closed
2 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30808/

@fowles
Copy link
Contributor Author

fowles commented Apr 17, 2020

I don't really understand your ci system, but I suspect those are spurious failures

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30822/

@jkrems
Copy link
Contributor

jkrems commented Apr 17, 2020

Trying to resume the build, let's see if that's enough.

@fowles
Copy link
Contributor Author

fowles commented Apr 21, 2020

I think this is ready to merge

@jkrems jkrems self-assigned this Apr 21, 2020
jkrems pushed a commit that referenced this pull request Apr 21, 2020
@fowles @jkrems
src: fix null deref in AllocatedBuffer::clear
10cc254 
An empty buffer can have a null environment.  Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.

PR-URL: #32892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@jkrems
Copy link
Contributor

jkrems commented Apr 21, 2020

Landed in 10cc254

@jkrems jkrems closed this Apr 21, 2020
@jkrems jkrems removed their assignment Apr 21, 2020
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@fowles @BethGriggs
src: fix null deref in AllocatedBuffer::clear
4221b1c 
An empty buffer can have a null environment.  Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.

PR-URL: #32892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@fowles @BridgeAR
src: fix null deref in AllocatedBuffer::clear
0fdc55f 
An empty buffer can have a null environment.  Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.

PR-URL: #32892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
Merged
targos pushed a commit that referenced this pull request Apr 30, 2020
@fowles @targos
src: fix null deref in AllocatedBuffer::clear
cbcaf09 
An empty buffer can have a null environment.  Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.

PR-URL: #32892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@targos targos mentioned this pull request May 2, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@fowles @targos
src: fix null deref in AllocatedBuffer::clear
cf16cb7 
An empty buffer can have a null environment.  Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.

PR-URL: #32892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@devnexen devnexen devnexen approved these changes

@addaleax addaleax addaleax approved these changes

@jkrems jkrems jkrems approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fowles @nodejs-github-bot @jkrems @jasnell @addaleax @devnexen @juanarbol