Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: removes unused params #32936

Closed
wants to merge 1 commit into from

Conversation

JesuHrz
Copy link
Contributor

@JesuHrz JesuHrz commented Apr 20, 2020

This PR removes the state param in the onFinished function
since it's never used within it.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Apr 20, 2020
@JesuHrz JesuHrz changed the title lib: removes unnecessary params lib: removes unused params Apr 20, 2020
@nodejs-github-bot
Copy link
Collaborator

@lpinca
Copy link
Member

lpinca commented Apr 20, 2020

Subsystem in commit message should be "stream" not "lib".

Removes the state param in the onFinished function
since it's never used within it.
@JesuHrz JesuHrz force-pushed the jesuhrz/removes-unused-params branch from d7dc43c to 22fdc41 Compare April 20, 2020 19:34
@JesuHrz
Copy link
Contributor Author

JesuHrz commented Apr 20, 2020

thanks @lpinca for the feedback, I just made this change

@JesuHrz JesuHrz changed the title lib: removes unused params stream: removes unused params Apr 20, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@addaleax
Copy link
Member

Landed in 24a4e61

addaleax pushed a commit that referenced this pull request Apr 25, 2020
Removes the state param in the onFinished function
since it's never used within it.

PR-URL: #32936
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@addaleax addaleax closed this Apr 25, 2020
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
Removes the state param in the onFinished function
since it's never used within it.

PR-URL: #32936
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@BethGriggs BethGriggs mentioned this pull request Apr 27, 2020
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
Removes the state param in the onFinished function
since it's never used within it.

PR-URL: #32936
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Trott pushed a commit to Trott/io.js that referenced this pull request May 9, 2020
Removes the state param in the onFinished function
since it's never used within it.

PR-URL: nodejs#32936
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants