Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: add importModuleDynamically option to compileFunction #32985

Merged
merged 1 commit into from
Apr 25, 2020
Merged

vm: add importModuleDynamically option to compileFunction #32985

merged 1 commit into from
Apr 25, 2020

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Apr 21, 2020

Fixes: #31860

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@devsnek devsnek added the vm Issues and PRs related to the vm subsystem. label Apr 21, 2020
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Apr 21, 2020
@devsnek devsnek force-pushed the feature-compilefunction-importmoduledynamically branch from 3d11e3b to d1926d1 Compare April 21, 2020 21:54
@devsnek devsnek marked this pull request as ready for review April 21, 2020 21:55
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30900/

@devsnek
Copy link
Member Author

devsnek commented Apr 23, 2020

cc @nodejs/vm @nodejs/documentation

@addaleax addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 24, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 24, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 24, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/30962/ (:heavy_check_mark:)

@devsnek
vm: add importModuleDynamically option to compileFunction
74c393d 
Fixes: nodejs#31860

PR-URL: nodejs#32985
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@devsnek devsnek force-pushed the feature-compilefunction-importmoduledynamically branch from d1926d1 to 74c393d Compare April 25, 2020 14:50
@devsnek devsnek merged commit 74c393d into nodejs:master Apr 25, 2020
@devsnek devsnek deleted the feature-compilefunction-importmoduledynamically branch April 25, 2020 14:50
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@devsnek @BethGriggs
vm: add importModuleDynamically option to compileFunction
d5038ec 
Fixes: #31860

PR-URL: #32985
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@devsnek @BridgeAR
vm: add importModuleDynamically option to compileFunction
84fd829 
Fixes: #31860

PR-URL: #32985
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@devsnek @BridgeAR
vm: add importModuleDynamically option to compileFunction
8809699 
Fixes: #31860

PR-URL: #32985
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
Merged
BridgeAR added a commit that referenced this pull request Apr 28, 2020
@BridgeAR
2020-04-28, Version 13.14.0 (Current)
9862aba 
Notable Changes:

* async_hooks**:
  * Merge `run` and `exit` methods (Andrey Pechkurov)
    #31950
  * Prevent sync methods of async storage exiting outer context
    (Stephen Belanger)
    #31950
* vm:
  * Add `importModuleDynamically` option to compileFunction (Gus
    Caplan)
    #32985

New core collaborators:

With this release, we welcome two new Node.js core collaborators:

* Juan José Arboleda @juanarbol
  #32906
* Andrey Pechkurov @puzpuzpuz
  #32817

PR-URL: #33122
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@devsnek @BethGriggs
vm: add importModuleDynamically option to compileFunction
4143c74 
Fixes: #31860

PR-URL: #32985
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BridgeAR added a commit that referenced this pull request Apr 28, 2020
@BridgeAR
2020-04-29, Version 13.14.0 (Current)
9fc74f1 
Notable Changes:

* async_hooks**:
  * Merge `run` and `exit` methods (Andrey Pechkurov)
    #31950
  * Prevent sync methods of async storage exiting outer context
    (Stephen Belanger)
    #31950
* vm:
  * Add `importModuleDynamically` option to compileFunction (Gus
    Caplan)
    #32985

New core collaborators:

With this release, we welcome two new Node.js core collaborators:

* Juan José Arboleda @juanarbol
  #32906
* Andrey Pechkurov @puzpuzpuz
  #32817

PR-URL: #33122
BethGriggs added a commit that referenced this pull request Apr 28, 2020
@BethGriggs
2020-04-29, Version 14.1.0 (Current)
9706e19 
Notable changes:

- deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha)
  [#32971](#32971)
- doc: add juanarbol as collaborator (Juan José Arboleda)
  [#32906](#32906)
- http: doc deprecate abort and improve docs (Robert Nagy)
  [#32807](#32807)
- module: do not warn when accessing `__esModule` of unfinished exports
  (Anna Henningsen) [#33048](#33048)
- n-api: detect deadlocks in thread-safe function (Gabriel Schulhof)
  [#32860](#32860)
- src: deprecate embedder APIs with replacements (Anna Henningsen)
  [#32858](#32858)
- stream:
  - don't emit end after close (Robert Nagy)
    [#33076](#33076)
  - don't wait for close on legacy streams (Robert Nagy)
    [#33058](#33058)
  - pipeline should only destroy un-finished streams (Robert Nagy)
    [#32968](#32968)
- vm: add importModuleDynamically option to compileFunction (Gus Caplan)
  [#32985](#32985)

PR-URL: #33103
@SimenB SimenB mentioned this pull request Apr 29, 2020
Open
21 tasks
BethGriggs added a commit that referenced this pull request Apr 29, 2020
@BethGriggs
2020-04-29, Version 14.1.0 (Current)
9ffd8e7 
Notable changes:

- deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha)
  [#32971](#32971)
- doc: add juanarbol as collaborator (Juan José Arboleda)
  [#32906](#32906)
- http: doc deprecate abort and improve docs (Robert Nagy)
  [#32807](#32807)
- module: do not warn when accessing `__esModule` of unfinished exports
  (Anna Henningsen) [#33048](#33048)
- n-api: detect deadlocks in thread-safe function (Gabriel Schulhof)
  [#32860](#32860)
- src: deprecate embedder APIs with replacements (Anna Henningsen)
  [#32858](#32858)
- stream:
  - don't emit end after close (Robert Nagy)
    [#33076](#33076)
  - don't wait for close on legacy streams (Robert Nagy)
    [#33058](#33058)
  - pipeline should only destroy un-finished streams (Robert Nagy)
    [#32968](#32968)
- vm: add importModuleDynamically option to compileFunction (Gus Caplan)
  [#32985](#32985)

PR-URL: #33103
BethGriggs added a commit that referenced this pull request Apr 29, 2020
@BethGriggs
2020-04-29, Version 14.1.0 (Current)
49db211 
Notable changes:

- deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha)
  [#32971](#32971)
- doc: add juanarbol as collaborator (Juan José Arboleda)
  [#32906](#32906)
- http: doc deprecate abort and improve docs (Robert Nagy)
  [#32807](#32807)
- module: do not warn when accessing `__esModule` of unfinished exports
  (Anna Henningsen) [#33048](#33048)
- n-api: detect deadlocks in thread-safe function (Gabriel Schulhof)
  [#32860](#32860)
- src: deprecate embedder APIs with replacements (Anna Henningsen)
  [#32858](#32858)
- stream:
  - don't emit end after close (Robert Nagy)
    [#33076](#33076)
  - don't wait for close on legacy streams (Robert Nagy)
    [#33058](#33058)
  - pipeline should only destroy un-finished streams (Robert Nagy)
    [#32968](#32968)
- vm: add importModuleDynamically option to compileFunction (Gus Caplan)
  [#32985](#32985)

PR-URL: #33103
BridgeAR added a commit that referenced this pull request Apr 29, 2020
@BridgeAR
2020-04-29, Version 13.14.0 (Current)
d7b02c3 
Notable Changes:

* async_hooks**:
  * Merge `run` and `exit` methods (Andrey Pechkurov)
    #31950
  * Prevent sync methods of async storage exiting outer context
    (Stephen Belanger)
    #31950
* vm:
  * Add `importModuleDynamically` option to compileFunction (Gus
    Caplan)
    #32985

New core collaborators:

With this release, we welcome two new Node.js core collaborators:

* Juan José Arboleda @juanarbol
  #32906
* Andrey Pechkurov @puzpuzpuz
  #32817

PR-URL: #33122
@targos targos mentioned this pull request May 6, 2020
Closed
@mcollina
Copy link
Member

Removed the backport request label because of #33166

@mcollina mcollina mentioned this pull request May 12, 2020
Closed
4 tasks
@rishabh3112 rishabh3112 mentioned this pull request Sep 4, 2020
Closed
devsnek added a commit to devsnek/node that referenced this pull request Sep 29, 2020
@devsnek
Revert "Revert "vm: add importModuleDynamically option to compileFunc…
12aff38 
…tion""

This reverts commit 2d5d773.

See: nodejs#32985
See: nodejs#33364
See: nodejs#33166
Fixes: nodejs#31860
@devsnek devsnek mentioned this pull request Sep 30, 2020
Merged
4 tasks
devsnek added a commit to devsnek/node that referenced this pull request Feb 5, 2021
@devsnek
Revert "Revert "vm: add importModuleDynamically option to compileFunc…
056a671 
…tion""

This reverts commit 2d5d773.

See: nodejs#32985
See: nodejs#33364
See: nodejs#33166
Fixes: nodejs#31860
devsnek added a commit to devsnek/node that referenced this pull request Feb 5, 2021
@devsnek
Revert "Revert "vm: add importModuleDynamically option to compileFunc…
28f5ec8 
…tion""

This reverts commit 2d5d773.

See: nodejs#32985
See: nodejs#33364
See: nodejs#33166
Fixes: nodejs#31860
devsnek added a commit that referenced this pull request Feb 5, 2021
@devsnek
vm: add importModuleDynamically option to compileFunction
bf2f2b7 
This reverts commit 2d5d773.

See: #32985
See: #33364
See: #33166
Fixes: #31860

PR-URL: #35431
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@devsnek @danielleadams
vm: add importModuleDynamically option to compileFunction
66a14d3 
This reverts commit 2d5d773.

See: #32985
See: #33364
See: #33166
Fixes: #31860

PR-URL: #35431
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. semver-minor PRs that contain new features and should be released in the next minor version. tools Issues and PRs related to the tools directory. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vm.compileFunction is missing importModuleDynamically
5 participants
@devsnek @nodejs-github-bot @mcollina @addaleax @targos