Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: make the builtInObjects set deterministic during bootstrap #33049

Closed
wants to merge 2 commits into from
Closed

lib: make the builtInObjects set deterministic during bootstrap #33049

wants to merge 2 commits into from

Commits on Apr 24, 2020

  1. lib: make the builtInObjects set deterministic during bootstrap 

    Make this list explicit instead of filtering over globalThis so that
this list is deterministic during the bootstrap regardless of:
a) Wether this file is required when the context is going to be
   serialized, or what the V8 flags are. V8 does not add
   SharedArrayBuffer, Atomics, WebAssembly, and other flaggable
   globals e.g. harmony ones to a context that will be serialized.
b) Wether this file is required before or after bootstrap
   (Node.js adds things like Buffer, URL, etc.)
    @joyeecheung
    joyeecheung committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    5bedf4d View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. fixup! lib: make the builtInObjects set deterministic during bootstrap

    @joyeecheung
    joyeecheung committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    5f01a4f View commit details
    Browse the repository at this point in the history