-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: patch V8 to 8.1.307.31 #33080
Closed
Closed
deps: patch V8 to 8.1.307.31 #33080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
v8 engine
Issues and PRs related to the V8 dependency.
label
Apr 26, 2020
addaleax
approved these changes
Apr 26, 2020
cjihrig
approved these changes
Apr 26, 2020
devsnek
approved these changes
Apr 26, 2020
juanarbol
approved these changes
Apr 27, 2020
addaleax
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Apr 27, 2020
Merged
Fast-track this because including it in v14.1.0 (#33103) has been requested and it’s only a few hours anyway? I’m okay with that. |
no objections |
addaleax
pushed a commit
that referenced
this pull request
Apr 28, 2020
Refs: v8/v8@8.1.307.30...8.1.307.31 PR-URL: #33080 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Landed in 563efb7 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
Refs: v8/v8@8.1.307.30...8.1.307.31 PR-URL: #33080 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
Refs: v8/v8@8.1.307.30...8.1.307.31 PR-URL: #33080 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos
added
dont-land-on-v10.x
and removed
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast-track
PRs that do not need to wait for 48 hours to land.
v8 engine
Issues and PRs related to the V8 dependency.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@8.1.307.30...8.1.307.31