Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused using declarations in node.cc #33261

Closed
wants to merge 1 commit into from
Closed

src: remove unused using declarations in node.cc #33261

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented May 6, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 6, 2020
@richardlau richardlau mentioned this pull request May 6, 2020
Merged
3 tasks
@richardlau
Copy link
Member

FWIW We have tooling to catch these. It wasn't flagging instances like the ones fixed in this PR. I've fixed up the tooling so it does: #33268

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31234/

@danbev
Copy link
Contributor Author

danbev commented May 13, 2020

Re-run of failing node-test-commit-freebsd ✔️

danbev added a commit that referenced this pull request May 13, 2020
@danbev
src: remove unused using declarations in node.cc
7f343c0 
PR-URL: #33261
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danbev
Copy link
Contributor Author

danbev commented May 13, 2020

Landed in 7f343c0.

@danbev danbev closed this May 13, 2020
@danbev danbev deleted the using-in-node.cc branch May 13, 2020 07:20
codebytere pushed a commit that referenced this pull request May 16, 2020
@danbev @codebytere
src: remove unused using declarations in node.cc
1999607 
PR-URL: #33261
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@danbev @codebytere
src: remove unused using declarations in node.cc
fe780a5 
PR-URL: #33261
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @richardlau @nodejs-github-bot @jasnell @lpinca @cjihrig @devnexen