Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add hr-time Web platform tests #33287

Closed
wants to merge 1 commit into from
Closed

test: add hr-time Web platform tests #33287

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented May 7, 2020

Refs: #32790

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 7, 2020
cjihrig
cjihrig approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31239/

targos added a commit that referenced this pull request May 10, 2020
@targos
test: add hr-time Web platform tests
c252f6c 
Refs: #32790

PR-URL: #33287
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@targos
Copy link
Member Author

targos commented May 10, 2020

Landed in c252f6c

@targos targos closed this May 10, 2020
@targos targos deleted the wpt-hr-time branch May 10, 2020 11:56
codebytere pushed a commit that referenced this pull request May 11, 2020
@targos @codebytere
test: add hr-time Web platform tests
1d2c81f 
Refs: #32790

PR-URL: #33287
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@targos @codebytere
test: add hr-time Web platform tests
cd92052 
Refs: #32790

PR-URL: #33287
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @jasnell @cjihrig @joyeecheung