Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: fix assertion error in WeakCallback #3329

Closed
wants to merge 2 commits into from
Closed

buffer: fix assertion error in WeakCallback #3329

wants to merge 2 commits into from

Commits on Oct 12, 2015

  1. buffer: fix assertion error in WeakCallback 

    `CallbackInfo` is now bound to `ArrayBuffer` instance, not `Uint8Array`,
therefore `SPREAD_ARG` will abort with:

    Assertion failed: ((object)->IsUint8Array())

Make changes necessary to migrate it to `ArrayBuffer`.

See: nodejs#3080 (comment)
    @indutny
    indutny committed Oct 12, 2015
    Configuration menu
    Copy the full SHA
    9d4624a View commit details
    Browse the repository at this point in the history

  2. ...

    @indutny
    indutny committed Oct 12, 2015
    Configuration menu
    Copy the full SHA
    a056988 View commit details
    Browse the repository at this point in the history