Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert tls.rootCertificates implementation and correct documentation #33313

Closed
wants to merge 2 commits into from
Closed

Revert tls.rootCertificates implementation and correct documentation #33313

wants to merge 2 commits into from

Commits on May 8, 2020

  1. Revert "src: fix missing extra ca in tls.rootCertificates" 

    A fix to tls.rootCertificates to have it correctly return the
process' current root certificates resulted in non-deterministic
behavior when Node.js is configured to use an OpenSSL system or
file-based certificate store.

The safest action is to revert the change and change the specification
for tls.rootCertificates to state that it only returns the bundled
certificates instead of the current ones.

Fixes: nodejs#32229
Refs: nodejs#32074
    @ebickle
    ebickle committed May 8, 2020
    Configuration menu
    Copy the full SHA
    56a430a View commit details
    Browse the repository at this point in the history

  2. doc: correct tls.rootCertificates to match implementation 

    Update tls.rootCertificates documentation to clarify that it returns
the bundled Node.js root certificates rather than the root certificates used by tls.createSecureContext.

Fixes: nodejs#32074
Refs: nodejs#32229
    @ebickle
    ebickle committed May 8, 2020
    Configuration menu
    Copy the full SHA
    3a65605 View commit details
    Browse the repository at this point in the history