Update events.md #33513
Closed
Update events.md #33513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the section refers to EventEmitter, instances in the example should be created of the same class EventEmitter.
nodejs-github-bot
added
doc
|
The top of the page has a (for the example): class MyEmitter extends EventEmitter {}So it looks like the current behavior is intentional. I'm +0 on changing it fwiw :] |
BridgeAR
reviewed
May 23, 2020
|
@benjamingr I had another look and the code block where |
|
Ping @shawsourav |
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
8ae28ff to
2935f72
Compare
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
jasnell
approved these changes
Jul 3, 2020
aduh95
added
the
author ready
|
Landed in 9e5a27a |
aduh95
pushed a commit
that referenced
this pull request
Oct 16, 2020
Since the section refers to EventEmitter, instances in the example should be created of the same class EventEmitter. PR-URL: #33513 Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
Since the section refers to EventEmitter, instances in the example should be created of the same class EventEmitter. PR-URL: #33513 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the section refers to EventEmitter, instances in the example should be created of the same class EventEmitter.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes