Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: perform bounds checking on error source line #33645

Closed
wants to merge 2 commits into from
Closed

src: perform bounds checking on error source line #33645

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

Fixes: #33578

/cc @devsnek Since I can’t reproduce, I didn’t feel 100 % comfortable to add a test here. If you can put your repro into the form of a regression test, feel free to push to this branch.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 29, 2020
@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:18
@addaleax addaleax requested a review from devsnek June 5, 2020 19:29
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 5, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/31739/ (:yellow_heart:)

@addaleax addaleax added the review wanted PRs that need reviews. label Jun 6, 2020
@addaleax addaleax requested review from jasnell and Trott June 8, 2020 18:42
@addaleax
Copy link
Member Author

addaleax commented Jun 9, 2020

Landed in 4678e44

@addaleax addaleax closed this Jun 9, 2020
addaleax added a commit that referenced this pull request Jun 9, 2020
@addaleax
src: perform bounds checking on error source line
4678e44 
Fixes: #33578

PR-URL: #33645
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax addaleax deleted the node-errors-sourceline-bounds branch June 9, 2020 13:23
@MylesBorins
Copy link
Contributor

Hey @addaleax this doesn't land cleanly on 14.x, it appears to make changes to source text that hasn't landed yet as part of #33491.

Would you up to making a backport

targos pushed a commit that referenced this pull request May 1, 2021
@addaleax @targos
src: perform bounds checking on error source line
ae9bd89 
Fixes: #33578

PR-URL: #33645
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@devsnek devsnek Awaiting requested review from devsnek

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIGSEGV in node::GetErrorSource
5 participants
@addaleax @nodejs-github-bot @MylesBorins @Trott @targos