Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.x backport] inspector: more conservative minimum stack size #33720

Commits on Jun 4, 2020

  1. inspector: more conservative minimum stack size

    PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely
    receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64,
    which is the musl architecture with the biggest MINSIGSTKSZ so let's
    use that as a lower bound and let's quadruple it just in case.
    
    Backport-PR-URL: nodejs#33720
    PR-URL: nodejs#27855
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    bnoordhuis authored and Flarna committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    f05a7a4 View commit details
    Browse the repository at this point in the history