-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Fix the typo in example output in url.md for url.hostname #33735
Conversation
@DerekNonGeneric - thanks, and you are right. the @darkrishabh - this change is not correct. At the same time, I guess the doc can be improved to make it more explicit, to avoid confusion. Let me know if you can come up with a sentence. |
Co-authored-by: James M Snell <jasnell@gmail.com>
Co-authored-by: James M Snell <jasnell@gmail.com>
Sorry for picking this up so late, I got involved in some family emergency. I agree with @jasnell and incorporated the change suggested. |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Landed in 665da27 |
PR-URL: #33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Currently in the
url.hostname
, the replacement example updates the hostname to useexample.com:82
but in the comment it's showing the expected output for the operation to be// Prints https://example.com:81/foo
It should be
// Prints https://example.com:82/foo
Checklist