-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: rectify --link-module usage #3379
Conversation
I'm not sure this was the intended behavior. @bmeck Thoughts? |
ping @bmeck |
The original intent was to have as little magic as possible since the mapping of some things can be complex and not a single name (such as node's internal use of 'internal/*'). I would be more prone to allow mapping a path to a native name rather than always do this. Basically, I want it to have as little magic as possible personally. That said, there is a use case for mapping paths to different builtin names. Perhaps discussing that prior to merging anything would be for the best. |
@bmeck this is just clarifying the configure option to what it actual does in more detail. LGTM if it LGTY. |
@Fishrock123 sounds good. LGTM |
PR-URL: #3379 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Thanks, landed in 753509f |
PR-URL: #3379 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
should be considered for LTS /cc @jasnell |
Can but not sure there's a critical need for it |
PR-URL: #3379 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Landed in v4.x-staging in ad65c82 |
PR-URL: #3379 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Modules imported by
--link-module
are not referenced by name but actually by path.