fs: streamline EISDIR error on different platforms

[lundibundi]

Previously upon calling file-only fs functions with a directory (or
presumably a directory of path ending with a forward slash '/') it would
result in EISDIR error on Linux but Windows would completely ignore trailing '/'
and perform operation on a file excluding it.

This introduces additional checks in fs code to make sure the trailing
slash is handled the same way across systems.

Fixes: #17801

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added (anything to add in the fs docs?)
• commit message follows commit guidelines

This currently adds checks in

• readFile/readFileSync
• open/openSync
• truncate/truncateSync
• writeFile/ writeFileSync
• readFile/ readFileSync
• createReadStream/createReadStreamSync
• createWriteStream/createWriteStreamSync

anything else I've missed?

/cc @nodejs/fs

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31823/

[addaleax]

I know it’s far from ideal that we the introduction of our internal error system also meant mixing POSIX/libuv errors with our own error codes, but since we already have EISDIR, I think it makes sense to keep using that…?

[lundibundi]

@addaleax done.

ping @nodejs/fs, this is ready for review.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31912/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31915/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32734/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32744/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32747/

[lundibundi]

/cc @addaleax @jasnell @ronag the implementation changed slightly to handle backward slash on Windows.

Also, anyone knows what can I do about test timeout on ARM? Should I separate these into a few tests? (On my machine the whole test takes less than a second though)

Edit: now also handles fs.promises (forgot about them the previous time)

[lundibundi]

@jasnell @addaleax @ronag @nodejs/fs this could use another review since implementation has changed slightly.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32891/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32893/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/33019/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/33022/

[lundibundi]

ping @addaleax @jasnell @ronag @nodejs/fs could this get another review since the implementation changed slightly and also I'd especially want to hear your opinion on this (is there a better way?)
https://github.com/nodejs/node/pull/33831/files#diff-d608fd0cbcac8df44557d8e49e206c7dR38-R41

[aduh95]

This needs a rebase.

[BridgeAR]

Ping @lundibundi

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

[github-actions]

Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.