Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: introduce codeowners again #33895

Closed
wants to merge 1 commit into from

Commits on Jun 18, 2020

  1. meta: introduce codeowners again

    The [Contributor's Survey
    results](nodejs/TSC#882) highlight the fact that
    it is often not easy for contributors to know who the right people are
    to talk to about a proposed change or who to ask for reviews of a given
    subsystem. We briefly toyed around with codeowners before when GitHub
    introduced it but just as quickly disabled it because the structure of
    our repository made it exceedingly difficult to get right.
    
    Rather than start with a codeowners for the entire project, I propose
    that we start with a small experiment focused on specific subsystems.
    Specifically, codeowners for modules, streams, net/tls, http/http2, and
    quic (once that lands). We can expand out from there as we see how
    things go with the minimal starter set. Initially this just enables
    codeowners for the `quic` subsystem.
    
    A couple of points:
    
    1. A codeowner should always be a team, never an individual person
    2. Each codeowner team should contain at least one TSC member (to
    provide coverage for signing off on semver-major changes)
    3. PRs touching any code with a codeowner must be signed off by at least
    one person on the codeowner team
    jasnell committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    a2a2d55 View commit details
    Browse the repository at this point in the history