Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: Abstracting options parse logic #34011

Closed
wants to merge 1 commit into from
Closed

src: Abstracting options parse logic #34011

wants to merge 1 commit into from

Conversation

zhangwinning
Copy link
Contributor

@zhangwinning zhangwinning commented Jun 22, 2020 •
edited
Loading

The parse options and parse stdio options is different from logic. so I take parse options logic out of spawn function. It's more clearly.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. labels Jun 22, 2020
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Jun 25, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32070/

@jasnell
Copy link
Member

jasnell commented Jun 25, 2020

Many failures in CI on this.

@jasnell jasnell removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 25, 2020
@github-actions github-actions bot mentioned this pull request Jun 26, 2020
Open
13 tasks
This was referenced Jun 27, 2020
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangwinning @nodejs-github-bot @jasnell @addaleax