-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update test-child-process-spawn-loop for Python 3 #34071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
added
the
python
PRs and issues that require attention from people who are familiar with Python.
label
Jun 26, 2020
jasnell
approved these changes
Jun 26, 2020
himself65
approved these changes
Jun 26, 2020
targos
approved these changes
Jun 26, 2020
lpinca
approved these changes
Jun 27, 2020
Fixes `SyntaxError: Missing parentheses in call to 'print'.` error when `python` resolves to Python 3. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: nodejs#34071 Refs: nodejs#29298 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Landed in b613933. |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2020
Fixes `SyntaxError: Missing parentheses in call to 'print'.` error when `python` resolves to Python 3. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #34071 Refs: #29298 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
Fixes `SyntaxError: Missing parentheses in call to 'print'.` error when `python` resolves to Python 3. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #34071 Refs: #29298 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Fixes `SyntaxError: Missing parentheses in call to 'print'.` error when `python` resolves to Python 3. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #34071 Refs: #29298 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
SyntaxError: Missing parentheses in call to 'print'.
error whenpython
resolves to Python 3.Refs: #29298
This test is in
pummel
so doesn't get run as part of the regular CIor default suite of tests (which is probably why this hasn't been
spotted before). It is run as part of the daily/nightly builds but those
seem to be broken due to
test-crypto-timing-safe-equal-benchmarks
failures (#34073, cc @Trott).
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes