Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: minor cleanups in quic_buffer #34087

Closed
wants to merge 2 commits into from
Closed

quic: minor cleanups in quic_buffer #34087

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jun 27, 2020

Minor additional cleanup to QuicBuffer

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@jasnell jasnell added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label Jun 27, 2020
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jun 27, 2020
@jasnell
Copy link
Member Author

jasnell commented Jun 27, 2020

QUIC CI: https://ci.nodejs.org/job/node-test-commit/39326/

addaleax
addaleax approved these changes Jun 27, 2020
View reviewed changes
src/quic/node_quic_buffer.cc Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32157/

@jasnell
Copy link
Member Author

jasnell commented Jun 30, 2020

QUIC CI: https://ci.nodejs.org/job/node-test-commit/39382/

jasnell added a commit that referenced this pull request Jun 30, 2020
@jasnell
quic: minor cleanups in quic_buffer
204f20f 
PR-URL: #34087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Jun 30, 2020

Landed in 204f20f

@jasnell jasnell closed this Jun 30, 2020
@MylesBorins
Copy link
Contributor

Marked as "backport-requested" because I do not believe quic is on 14.x yet. Should we change the label to "dont-land"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @nodejs-github-bot @MylesBorins @addaleax @devnexen @targos