Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip some IBM i unsupported test cases #34118

Closed
wants to merge 1 commit into from
Closed

test: skip some IBM i unsupported test cases #34118

wants to merge 1 commit into from

Conversation

dmabupt
Copy link
Contributor

@dmabupt dmabupt commented Jun 29, 2020

Issuing a shutdown() on IBM i PASE with parameter SHUT_WR also sends a normal close sequence to the partner program.
This leads to timing issues and ECONNRESET failures in some test cases.
Refs: libuv/libuv#2782

Issuing a shutdown() on IBM i PASE with parameter SHUT_WR
also sends a normal close sequence to the partner program.
This leads to timing issues and ECONNRESET failures in some
test cases.
Refs: libuv/libuv#2782
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 29, 2020
@richardlau richardlau added the ibm i Issues and PRs related to the IBM i platform. label Jun 29, 2020
@richardlau
Copy link
Member

richardlau commented Jun 29, 2020

IBM i CI: https://ci.nodejs.org/job/node-test-commit-ibmi/8/nodes=ibmi72-ppc64/
(1 failure, which is an improvement -- here's a CI with master for comparison: https://ci.nodejs.org/job/node-test-commit-ibmi/10/nodes=ibmi72-ppc64/)

@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 3, 2020
@richardlau
Copy link
Member

With this PR we're down to a single test failure on IBM i, which is an improvement. Assuming the regular CI (which does not include IBM i) passes we can land this. I'll continue to work with @dmabupt and the rest of the @nodejs/platform-ibmi team to get the IBM i CI passing (i.e. no test failures) before hooking it up to be part of the regular CI.

jasnell pushed a commit that referenced this pull request Jul 3, 2020
Issuing a shutdown() on IBM i PASE with parameter SHUT_WR
also sends a normal close sequence to the partner program.
This leads to timing issues and ECONNRESET failures in some
test cases.
Refs: libuv/libuv#2782

PR-URL: #34118
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jul 3, 2020

Landed in 07bbadb

@jasnell jasnell closed this Jul 3, 2020
@dmabupt dmabupt deleted the skip_somecase_on_ibmi branch July 3, 2020 23:19
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
Issuing a shutdown() on IBM i PASE with parameter SHUT_WR
also sends a normal close sequence to the partner program.
This leads to timing issues and ECONNRESET failures in some
test cases.
Refs: libuv/libuv#2782

PR-URL: #34118
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
Issuing a shutdown() on IBM i PASE with parameter SHUT_WR
also sends a normal close sequence to the partner program.
This leads to timing issues and ECONNRESET failures in some
test cases.
Refs: libuv/libuv#2782

PR-URL: #34118
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Issuing a shutdown() on IBM i PASE with parameter SHUT_WR
also sends a normal close sequence to the partner program.
This leads to timing issues and ECONNRESET failures in some
test cases.
Refs: libuv/libuv#2782

PR-URL: #34118
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. ibm i Issues and PRs related to the IBM i platform. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants