Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update wording in "Two reading modes" #34119

Closed
wants to merge 1 commit into from
Closed

doc: Update wording in "Two reading modes" #34119

wants to merge 1 commit into from

Conversation

julienp
Copy link
Contributor

@julienp julienp commented Jun 29, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jun 29, 2020
@gireeshpunathil
Copy link
Member

looks good, with the trailing white space removed in line 717, as shown in the linter

@julienp
Copy link
Contributor Author

julienp commented Jun 30, 2020

I've fixed the lint issue.

jasnell pushed a commit that referenced this pull request Jul 3, 2020
@julienp @jasnell
doc: update wording in "Two reading modes"
647babc 
PR-URL: #34119
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jul 3, 2020

Landed in 647babc

@jasnell jasnell closed this Jul 3, 2020
@julienp julienp deleted the patch-2 branch July 4, 2020 17:39
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
@julienp @MylesBorins
doc: update wording in "Two reading modes"
c1e6e23 
PR-URL: #34119
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
@julienp @MylesBorins
doc: update wording in "Two reading modes"
aaba1c0 
PR-URL: #34119
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@julienp @addaleax
doc: update wording in "Two reading modes"
089a447 
PR-URL: #34119
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@julienp @gireeshpunathil @jasnell @lpinca @himself65 @nodejs-github-bot